Changeset 19001 in osm for applications/editors/josm/plugins

Timestamp:

2009-12-09T00:02:55+01:00 (15 years ago)

Author:

casualwalker

Message:

LiveGps:

• Set default refresh time to 5 seconds (instead of 5000)
• Setting refresh time to 0 disables the feature (suppressing frequent updates)

File:

• applications/editors/josm/plugins/livegps/src/livegps/LiveGpsSuppressor.java (modified) (3 diffs)

applications/editors/josm/plugins/livegps/src/livegps/LiveGpsSuppressor.java

@@ -21 +21 @@
          * Default sleep time is 5 seconds.
          */
-        private static final int DEFAULT_SLEEP_TIME = 5000;
+        private static final int DEFAULT_SLEEP_TIME = 5;
 
         /**
@@ -46 +46 @@
 
                 shutdownFlag = false;
-                while (!shutdownFlag) {
+                // stop the thread, when explicitely shut down or when disabled by
+                // config setting
+                while (!shutdownFlag && isEnabled()) {
                         setAllowUpdate(true);
 
@@ -92 +94 @@
         public synchronized boolean isAllowUpdate() {
 
-                if (allowUpdate) {
-                        allowUpdate = false;
+                // if disabled, always permit a re-draw.
+                if (!isEnabled()) {
                         return true;
                 } else {
-                        return false;
+
+                        if (allowUpdate) {
+                                allowUpdate = false;
+                                return true;
+                        } else {
+                                return false;
+                        }
                 }
+        }
+
+        /**
+         * A value below 1 disables this feature.
+         * This ensures that a small value does not run this thread
+         * in a tight loop.
+         * 
+         * @return true, if suppressing is enabled
+         */
+        private boolean isEnabled() {
+                return this.sleepTime > 0;
         }