Changeset 18836 in josm

Timestamp:

2023-09-20T20:08:14+02:00 (9 months ago)

Author:

taylor.smock

Message:

Reduce memory allocations from SplashScreenProgressRenderer#setTasks

This reduces startup memory allocations from that method to effectively zero from
475 MB. There is a total reduction of ~580 MB (or ~1/3 of startup memory
allocations). This reduces the GC pressure significantly, and reduces startup
time by 2.5-3.8 seconds.

Most of the additional memory allocation reductions come from not needing to
repaint the text caret after the setTasks call.

File:

• trunk/src/org/openstreetmap/josm/gui/SplashScreen.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/SplashScreen.java

@@ -391 +391 @@
                 + "<style>ul {margin-top: 0; margin-bottom: 0; padding: 0;} li {margin: 0; padding: 0;}</style>";
 
+        private String lastTasks;
+
         protected void build() {
             setLayout(new GridBagLayout());
@@ -416 +418 @@
          */
         public void setTasks(String tasks) {
-            lblTaskTitle.setText(LABEL_HTML + tasks);
-            lblTaskTitle.setCaretPosition(lblTaskTitle.getDocument().getLength());
-            scrollPane.getHorizontalScrollBar().setValue(0);
+            // Only update the display when the tasks change
+            if (!Objects.equals(lastTasks, tasks)) {
+                lastTasks = tasks;
+                lblTaskTitle.setText(LABEL_HTML + tasks);
+                lblTaskTitle.setCaretPosition(lblTaskTitle.getDocument().getLength());
+                scrollPane.getHorizontalScrollBar().setValue(0);
+            }
         }
     }