Changeset 18824 in josm for trunk/src/org/openstreetmap

Timestamp:

2023-09-07T19:36:52+02:00 (2 years ago)

Author:

taylor.smock

Message:

Fix #23153: Remote Control API call is adding hashtags many times

This occurs due to adding the hashtags to the comment multiple times.

This is fixed by doing the following:
1) When finding hashtags from a comment, only return the distinct hashtags
2) When adding hashtags from the dataset, only add hashtags that are not already

part of the comment.

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• io/UploadDialogModel.java (modified) (5 diffs)
• tagging/presets/TaggingPresetSelector.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/io/UploadDialogModel.java

@@ -76 +76 @@
      */
     String findHashTags(String comment) {
-        String hashtags = Arrays.stream(comment.split("\\s", -1))
+        String foundHashtags = Arrays.stream(comment.split("\\s", -1))
             .map(s -> Utils.strip(s, ",;"))
             .filter(s -> s.matches("#[a-zA-Z0-9][-_a-zA-Z0-9]+"))
-            .collect(Collectors.joining(";"));
-        return hashtags.isEmpty() ? null : hashtags;
+            .distinct().collect(Collectors.joining(";"));
+        return foundHashtags.isEmpty() ? null : foundHashtags;
     }
 
@@ -96 +96 @@
                 Set<String> sanitizedHashtags = new LinkedHashSet<>();
                 for (String hashtag : hashtags.split(";", -1)) {
-                    sanitizedHashtags.add(hashtag.startsWith("#") ? hashtag : "#" + hashtag);
+                    if (comment == null || !comment.contains(hashtag)) {
+                        sanitizedHashtags.add(hashtag.startsWith("#") ? hashtag : "#" + hashtag);
+                    }
                 }
                 if (!sanitizedHashtags.isEmpty()) {
@@ -108 +110 @@
     /**
      * Inserts/updates/deletes a tag.
-     *
+     * <p>
      * Existing keys are updated. Others are added. A value of {@code null}
      * deletes the key.
@@ -131 +133 @@
     /**
      * Inserts/updates/deletes a tag.
-     *
+     * <p>
      * Existing keys are updated. Others are added. A value of {@code null}
      * deletes the key.
@@ -147 +149 @@
     /**
      * Inserts/updates/deletes all tags from {@code map}.
-     *
+     * <p>
      * Existing keys are updated. Others are added. A value of {@code null}
      * deletes the key.

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java

@@ -20 +20 @@
 import java.util.Set;
 import java.util.regex.Pattern;
-import java.util.stream.Collectors;
 
 import javax.swing.AbstractAction;