Changeset 18815 in josm for trunk/src/org

Timestamp:

2023-08-21T18:42:32+02:00 (10 months ago)

Author:

taylor.smock

Message:

Improve paste behavior of large amounts of data

Both SelectionListDialog and MapStatus can use the consolidated events, which
drastically reduces the amount of time spent pasting large amounts of data. This
reduces the time spent in their listener methods by >99%.

The test paste of 41k objects took ~20s after the change and ~80s prior to the change.

A good chunk of the remaining time spent pasting is from checking to see whether
an upload is needed. Fixing that will take a lot more work, since there is
currently no concept of consolidated events for that specific listener type.

This was found while investigating #4145.

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• MapStatus.java (modified) (1 diff)
• dialogs/SelectionListDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/MapStatus.java

@@ -961 +961 @@
 
         Config.getPref().addPreferenceChangeListener(this);
-        DatasetEventManager.getInstance().addDatasetListener(this, FireMode.IN_EDT);
+        DatasetEventManager.getInstance().addDatasetListener(this, FireMode.IN_EDT_CONSOLIDATED);
         SelectionEventManager.getInstance().addSelectionListenerForEdt(this);
 

trunk/src/org/openstreetmap/josm/gui/dialogs/SelectionListDialog.java

@@ -175 +175 @@
         SelectionEventManager.getInstance().addSelectionListenerForEdt(actShowHistory);
         SelectionEventManager.getInstance().addSelectionListenerForEdt(model);
-        DatasetEventManager.getInstance().addDatasetListener(model, FireMode.IN_EDT);
+        DatasetEventManager.getInstance().addDatasetListener(model, FireMode.IN_EDT_CONSOLIDATED);
         MainApplication.getLayerManager().addActiveLayerChangeListener(actSearch);
         // editLayerChanged also gets the selection history of the level. Listener calls setJOSMSelection when fired.