Changeset 18724 in josm for trunk/src/org/openstreetmap

Timestamp:

2023-05-10T19:37:19+02:00 (20 months ago)

Author:

taylor.smock

Message:

Fix #22808: Add bulk removal method to DataSet

This fixes an issue where selecting a large number of objects that will be
removed after pasting them will cause a massive number of events to be fired.

Location:

trunk/src/org/openstreetmap/josm

Files:

• command/AddPrimitivesCommand.java (modified) (2 diffs)
• data/osm/DataSet.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/command/AddPrimitivesCommand.java

@@ -18 +18 @@
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.PrimitiveData;
+import org.openstreetmap.josm.data.osm.PrimitiveId;
 import org.openstreetmap.josm.tools.CheckParameterUtil;
 
@@ -128 +129 @@
         }
         // reversed order, see #14620
-        for (int i = createdPrimitives.size() - 1; i >= 0; i--) {
-            OsmPrimitive osm = createdPrimitives.get(i);
-            Optional<PrimitiveData> previous = preExistingData.stream()
-                    .filter(pd -> pd.getPrimitiveId().equals(osm.getPrimitiveId())).findAny();
-            if (previous.isPresent()) {
-                osm.load(previous.get());
-            } else {
-                ds.removePrimitive(osm);
-            }
-        }
+        final List<PrimitiveId> toRemove = new ArrayList<>(this.createdPrimitives.size());
+        ds.update(() -> {
+                    for (int i = createdPrimitives.size() - 1; i >= 0; i--) {
+                        OsmPrimitive osm = createdPrimitives.get(i);
+                        Optional<PrimitiveData> previous = preExistingData.stream()
+                                .filter(pd -> pd.getPrimitiveId().equals(osm.getPrimitiveId())).findAny();
+                        if (previous.isPresent()) {
+                            osm.load(previous.get());
+                        } else {
+                            toRemove.add(osm);
+                        }
+                    }
+                });
+        ds.removePrimitives(toRemove);
     }
 

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -6 +6 @@
 import java.awt.geom.Area;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
@@ -546 +547 @@
     /**
      * Removes a primitive from the dataset. This method only removes the
-     * primitive form the respective collection of primitives managed
+     * primitive from the respective collection of primitives managed
      * by this dataset, i.e. from {@code store.nodes}, {@code store.ways}, or
      * {@code store.relations}. References from other primitives to this
@@ -565 +566 @@
     }
 
+    /**
+     * Removes primitives from the dataset. This method only removes the
+     * primitives from the respective collection of primitives managed
+     * by this dataset, i.e. from {@code store.nodes}, {@code store.ways}, or
+     * {@code store.relations}. References from other primitives to this
+     * primitive are left unchanged.
+     *
+     * @param primitiveIds the ids of the primitive
+     * @throws IllegalStateException if the dataset is read-only
+     * @since 18724
+     */
+    public void removePrimitives(PrimitiveId... primitiveIds) {
+        this.removePrimitives(Arrays.asList(primitiveIds));
+    }
+
+    /**
+     * Removes primitives from the dataset. This method only removes the
+     * primitives from the respective collection of primitives managed
+     * by this dataset, i.e. from {@code store.nodes}, {@code store.ways}, or
+     * {@code store.relations}. References from other primitives to this
+     * primitive are left unchanged.
+     *
+     * @param primitiveIds the ids of the primitive
+     * @throws IllegalStateException if the dataset is read-only
+     * @since 18724
+     */
+    public void removePrimitives(Collection<PrimitiveId> primitiveIds) {
+        checkModifiable();
+        final List<PrimitiveId> selected = new ArrayList<>();
+        update(() -> {
+            clearSelection(primitiveIds);
+            final List<OsmPrimitive> removed = new ArrayList<>(primitiveIds.size());
+            for (PrimitiveId primitiveId : primitiveIds) {
+                OsmPrimitive primitive = this.getPrimitiveByIdChecked(primitiveId);
+                if (primitive == null) {
+                    continue;
+                } else if (primitive.isSelected()) {
+                    selected.add(primitive);
+                }
+                this.removePrimitiveFromStorage(primitive);
+                removed.add(primitive);
+            }
+            firePrimitivesRemoved(removed, false);
+        });
+        if (!selected.isEmpty()) {
+            throw new DataIntegrityProblemException("Primitives were re-selected by a selection listener: "
+            + selected.stream().map(PrimitiveId::toString).collect(Collectors.joining(", ")));
+        }
+    }
+
     private void removePrimitiveImpl(OsmPrimitive primitive) {
         clearSelection(primitive.getPrimitiveId());
@@ -570 +621 @@
             throw new DataIntegrityProblemException("Primitive was re-selected by a selection listener: " + primitive);
         }
+        this.removePrimitiveFromStorage(primitive);
+    }
+
+    private void removePrimitiveFromStorage(OsmPrimitive primitive) {
         store.removePrimitive(primitive);
         allPrimitives.remove(primitive);