Changeset 18691 in josm for trunk/test

Timestamp:

2023-03-14T14:37:10+01:00 (3 years ago)

Author:

taylor.smock

Message:

Significantly reduce cost of large presets like Name Suggestion Index

This reduces the startup CPU of TaggingPresets#initialize by ~29% and the memory
by ~55%. This was done by adding a batch addActiveLayerChangeListeners method
in MainLayerManager.

This additionally reduces the cost of
TaggingPresetSelect$PresetClassification.simplifyString (used by the preset
search dialog) by ~28% CPU cycles and ~58% memory allocations. This was done by
having a single static Pattern which was reused -- most of the remaining
potentially reducible cost for simplifyString is from Matcher initialization.
This would require thread local variables, so may not be worthwhile for now.

Location:

trunk/test

Files:

• functional/org/openstreetmap/josm/io/MultiFetchServerObjectReaderTest.java (modified) (1 diff)
• performance/org/openstreetmap/josm/io/OsmReaderPerformanceTest.java (modified) (1 diff)
• unit/org/openstreetmap/josm/data/validation/routines/DomainValidatorTestIT.java (modified) (1 diff)
• unit/org/openstreetmap/josm/gui/datatransfer/ClipboardUtilsTest.java (modified) (1 diff)
• unit/org/openstreetmap/josm/gui/datatransfer/LayerTransferableTest.java (modified) (1 diff)

trunk/test/functional/org/openstreetmap/josm/io/MultiFetchServerObjectReaderTest.java

@@ -11 +11 @@
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
-import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.OutputStreamWriter;

trunk/test/performance/org/openstreetmap/josm/io/OsmReaderPerformanceTest.java

@@ -7 +7 @@
 import java.io.ByteArrayOutputStream;
 import java.io.File;
-import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;

trunk/test/unit/org/openstreetmap/josm/data/validation/routines/DomainValidatorTestIT.java

@@ -23 +23 @@
 import java.io.Closeable;
 import java.io.File;
-import java.io.FileInputStream;
 import java.io.FileOutputStream;
 import java.io.IOException;

trunk/test/unit/org/openstreetmap/josm/gui/datatransfer/ClipboardUtilsTest.java

@@ -15 +15 @@
 import java.awt.datatransfer.Transferable;
 import java.awt.datatransfer.UnsupportedFlavorException;
-import java.io.IOException;
 
 import net.trajano.commons.testing.UtilityClassTestUtil;

trunk/test/unit/org/openstreetmap/josm/gui/datatransfer/LayerTransferableTest.java

@@ -16 +16 @@
 import org.junit.jupiter.api.Test;
 import org.openstreetmap.josm.gui.datatransfer.LayerTransferable.Data;
-import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.LayerManagerTest;
 import org.openstreetmap.josm.gui.layer.LayerManagerTest.TestLayer;