Changeset 18472 in josm

Timestamp:

2022-06-08T17:33:09+02:00 (2 years ago)

Author:

taylor.smock

Message:

Fix some coverity warnings

• CID 1489777: FB.RV_RETURN_VALUE_IGNORED_BAD_PRACTICE Fixed by using Files.deleteIfExists instead of File.delete. We do catch the security exception and print a message for the user.
• CID 1489773: FORWARD_NULL Fixed by synchronizing around the potential null object. Shouldn't be too expensive, as it is mostly UI loop.

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/SessionSaveAction.java (modified) (4 diffs)
• gui/io/UploadDialog.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/actions/SessionSaveAction.java

@@ -14 +14 @@
 import java.io.IOException;
 import java.lang.ref.WeakReference;
+import java.nio.file.Files;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -53 +54 @@
 import org.openstreetmap.josm.gui.layer.LayerManager.LayerOrderChangeEvent;
 import org.openstreetmap.josm.gui.layer.LayerManager.LayerRemoveEvent;
+import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.gui.util.WindowGeometry;
 import org.openstreetmap.josm.gui.widgets.AbstractFileChooser;
@@ -252 +254 @@
             if (removeFileOnSuccess != null) {
                 PreferencesUtils.removeFromList(Config.getPref(), "file-open.history", removeFileOnSuccess.getCanonicalPath());
-                removeFileOnSuccess.delete();
+                Files.deleteIfExists(removeFileOnSuccess.toPath());
                 removeFileOnSuccess = null;
             }
             showSavedNotification(savingNotification, sessionFile.getName());
+        } catch (SecurityException ex) {
+            Logging.error(ex);
+            if (removeFileOnSuccess != null) {
+                final String path = removeFileOnSuccess.getPath();
+                GuiHelper.runInEDT(() -> {
+                    Notification notification = new Notification(tr("Could not delete file: {0}\r{1}", path, ex.getMessage()));
+                    notification.setIcon(JOptionPane.WARNING_MESSAGE);
+                    notification.show();
+                });
+            } else {
+                // We should never hit this, unless something changes in the try block.
+                throw new JosmRuntimeException(ex);
+            }
         } catch (IOException ex) {
             Logging.error(ex);
@@ -273 +288 @@
     /**
      * Sets the current session file. Asks the user if necessary
-     * @param saveAs alwas ask the user
+     * @param saveAs always ask the user
      * @param zipRequired zip
      * @return if the user was asked

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -97 +97 @@
 
     private transient DataSet dataSet;
-    private ChangeListener changesetTagListener;
+    private transient ChangeListener changesetTagListener;
 
     /**
@@ -372 +372 @@
      * the changeset tags.
      */
-    public void setChangesetTagsModifiedProgramatically() {
+    public synchronized void setChangesetTagsModifiedProgramatically() {
         final Color originalColor = this.tpConfigPanels.getBackgroundAt(1);
         this.tpConfigPanels.setBackgroundAt(1, WARNING_BACKGROUND);
@@ -383 +383 @@
                 tpConfigPanels.setBackgroundAt(1, originalColor);
                 tpConfigPanels.setIconAt(1, ImageProvider.get("apply"));
-                this.tpConfigPanels.removeChangeListener(this.changesetTagListener);
-                changesetTagListener = null;
+                synchronized (this) {
+                    this.tpConfigPanels.removeChangeListener(this.changesetTagListener);
+                    changesetTagListener = null;
+                }
             }
         };
@@ -575 +577 @@
         if (e.getKey() != null
                 && e.getSource() != getClass()
-                && e.getSource() != BasicUploadSettingsPanel.class) {
-            switch (e.getKey()) {
-                case "osm-server.url":
-                    osmServerUrlChanged(e.getNewValue());
-                    break;
-                default:
-                    return;
-            }
+                && e.getSource() != BasicUploadSettingsPanel.class
+                && "osm-server.url".equals(e.getKey())) {
+            osmServerUrlChanged(e.getNewValue());
         }
     }
@@ -643 +640 @@
         setUploadedPrimitives(null);
         dataSet = null;
-        if (this.changesetTagListener != null) {
-            this.changesetTagListener.stateChanged(null);
-            this.tpConfigPanels.removeChangeListener(this.changesetTagListener);
-            this.changesetTagListener = null;
+        synchronized (this) {
+            if (this.changesetTagListener != null) {
+                this.changesetTagListener.stateChanged(null);
+                this.tpConfigPanels.removeChangeListener(this.changesetTagListener);
+                this.changesetTagListener = null;
+            }
         }
     }