Changeset 18454 in josm for trunk/src/org

Timestamp:

2022-05-19T20:09:13+02:00 (2 years ago)

Author:

taylor.smock

Message:

Fix #21558: IOOBE in NotesDialog$NoteTableModel.getElementAt

This is caused when a user has a filter in the note panel,
and performs an action that removes the last note from
the panel.

Example:

1. User filters on "open"
2. User closes all notes

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/NotesDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/NotesDialog.java

@@ -408 +408 @@
                 int selectedIndex = displayList.getSelectedIndex();
                 noteData.closeNote(note, dialog.getInputText());
-                noteData.setSelectedNote(model.getElementAt(selectedIndex));
+                // This is required since filtering may cause the model to not have any visible elements
+                if (model.getSize() > 0) {
+                    noteData.setSelectedNote(model.getElementAt(selectedIndex));
+                } else {
+                    noteData.setSelectedNote(null);
+                }
             }
         }