Changeset 18434 in josm for trunk/test/unit

Timestamp:

2022-04-21T21:54:17+02:00 (3 years ago)

Author:

taylor.smock

Message:

Dependency updates

JCSCacheManager was modified to move away from methods deprecated in JCS 3.1.

TestUtils was modified so that we are only testing Java versions that byte
buddy might not understand, and to use the non-shaded version of byte buddy
(equalsverifier is no longer a fat jar).

ivy.xml:

• commons-jcs3-core: 3.0 -> 3.1
  • Full changelog: ​https://commons.apache.org/proper/commons-jcs/changes-report.html#a3.1
• metadata-extractor: 2.16.0 -> 2.17.0
  • Full changelog: ​https://github.com/drewnoakes/metadata-extractor/releases/tag/2.17.0
• jacoco: 0.8.7 -> 0.8.8
  • Official support for Java 17 and Java 18, experimental support for Java 19 class files
  • Full changelog: ​https://www.jacoco.org/jacoco/trunk/doc/changes.html
• spotbugs: 4.5.2 -> 4.6.0
  • New bug type (SSD_DO_NOT_USE_INSTANCE_LOCK_ON_SHARED_STATIC_DATA)
  • Full changelog: ​https://github.com/spotbugs/spotbugs/releases/tag/4.6.0
• wiremock: 2.32.0 -> 2.33.1
  • Fix CVE-2020-36518
  • Changelog for 2.33.0: ​https://github.com/wiremock/wiremock/releases/tag/2.33.0
  • Changelog for 2.33.1: ​https://github.com/wiremock/wiremock/releases/tag/2.33.1
• classgraph: 4.8.138 -> 4.8.146
  • Fixes handling for some URLs (jar:file:jarname.jar!/)
• equalsverifier: 3.8.1 -> 3.10
  • Better record support
  • Multi-Release JAR (also two jars, equalsverifier and equalsverifier-nodep -- -nodep is a shaded fat jar)
  • Fix an issue when testing sealed classes
  • Full changelog: ​https://github.com/jqno/equalsverifier/blob/equalsverifier-3.10/CHANGELOG.md
• awaitility: 4.1.1 -> 4.2.0
  • Fixes some bugs with respect to shutdown behavior and small intervals
  • Full changelog: ​https://github.com/awaitility/awaitility/blob/awaitility-4.2.0/changelog.txt

tools/ivy.xml:

• javacc 7.0.10 -> 7.0.11
  • Full changelog: ​https://github.com/javacc/javacc/blob/javacc-7.0.11/docs/release-notes.md
• checkstyle: 9.2.1 -> 9.3 (end of the line for Java 8 -- checkstyle 10 requires Java 11+)
  • Fix OOM
  • Support JEP 406
  • Add UnusedVariable check
  • Full changelog: ​https://checkstyle.sourceforge.io/releasenotes.html#Release_9.3
• proguard-ant: 7.2.0-beta5 -> 7.2.1
  • Better support for Java 18
  • Full changelog: ​https://github.com/Guardsquare/proguard/releases/tag/v7.2.1
• pmd: 6.41.0 -> 6.44.0
  • Supports Java 18
  • FinalParameterInAbstractMethod
  • Full release notes: ​https://pmd.github.io/pmd-6.44.0/pmd_release_notes.html
• spotbugs: 4.5.2 -> 4.6.0
  • SSD_DO_NOT_USE_INSTANCE_LOCK_ON_SHARED_STATIC_DATA
  • Full changelog: ​https://github.com/spotbugs/spotbugs/releases/tag/4.6.0
• animal-sniffer-ant-tasks: 1.20 -> 1.21
  • Cache signatures to speed up multiple runs
  • Full changelog: ​https://github.com/mojohaus/animal-sniffer/releases/tag/animal-sniffer-parent-1.21

File:

• trunk/test/unit/org/openstreetmap/josm/TestUtils.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/TestUtils.java

@@ -64 +64 @@
 import com.github.tomakehurst.wiremock.WireMockServer;
 import com.github.tomakehurst.wiremock.core.WireMockConfiguration;
-
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.github.classgraph.ClassGraph;
@@ -492 +491 @@
     @SuppressWarnings("null")
     public static void assumeWorkingEqualsVerifier() {
-        if (Utils.getJavaVersion() >= 16) {
+        // See https://github.com/raphw/byte-buddy/blob/master/byte-buddy-dep/src/main/java/net/bytebuddy/ClassFileVersion.java
+        // for currently supported Java versions.
+        if (Utils.getJavaVersion() >= 19) {
             // Byte Buddy often supports new class file versions for current EA releases if its experimental flag is set to true
             System.setProperty("net.bytebuddy.experimental", "true");
+        } else {
+            return;
         }
         try {
             // Workaround to https://github.com/jqno/equalsverifier/issues/177
             // Inspired by https://issues.apache.org/jira/browse/SOLR-11606
-            nl.jqno.equalsverifier.internal.lib.bytebuddy.ClassFileVersion.ofThisVm();
+            // Note: if we change to the equalsverifier fat jar, use nl.jqno.equalsverifier.internal.lib instead of net
+            net.bytebuddy.ClassFileVersion.ofThisVm();
         } catch (IllegalArgumentException e) {
             assumeFalse(e != null);