Changeset 18366 in josm for trunk/src/org

Timestamp:

2022-01-26T20:13:22+01:00 (3 years ago)

Author:

taylor.smock

Message:

Replace usages of System.exit with Lifecycle.exitJosm

This fixes some coverity scan issues (spotbugs) with respect to exiting the VM.

See #15182: Standalone JOSM validator

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/projection/ProjectionCLI.java (modified) (3 diffs)
• data/validation/ValidatorCLI.java (modified) (2 diffs)
• gui/MainApplication.java (modified) (2 diffs)
• gui/mappaint/RenderingCLI.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/projection/ProjectionCLI.java

@@ -20 +20 @@
 import org.openstreetmap.josm.data.coor.LatLon;
 import org.openstreetmap.josm.data.coor.conversion.LatLonParser;
+import org.openstreetmap.josm.spi.lifecycle.Lifecycle;
 import org.openstreetmap.josm.tools.OptionParser;
 
@@ -76 +77 @@
         } catch (ProjectionConfigurationException | IllegalArgumentException | IOException ex) {
             System.err.println(tr("Error: {0}", ex.getMessage()));
-            System.exit(1);
+            Lifecycle.exitJosm(true, 1);
         }
-        System.exit(0);
+        Lifecycle.exitJosm(true, 0);
     }
 
@@ -86 +87 @@
     private static void showHelp() {
         System.out.println(getHelp());
-        System.exit(0);
+        Lifecycle.exitJosm(true, 0);
     }
 

trunk/src/org/openstreetmap/josm/data/validation/ValidatorCLI.java

@@ -69 +69 @@
  */
 public class ValidatorCLI implements CLIModule {
-        /**
-         * The unique instance.
-         */
+    /**
+     * The unique instance.
+     */
     public static final ValidatorCLI INSTANCE = new ValidatorCLI();
 
@@ -385 +385 @@
         case HELP:
             showHelp();
-            System.exit(0);
+            Lifecycle.exitJosm(true, 0);
             break;
         case DEBUG:

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -278 +278 @@
             } catch (IllegalArgumentException e) {
                 System.err.println(e.getMessage());
-                System.exit(1);
+                Lifecycle.exitJosm(true, 1);
             }
             mainJOSM(args);
@@ -1241 +1241 @@
                             tr("''{0}'' is not a valid value for argument ''{1}''. Possible values are {2}, possibly delimited by commas.",
                             s.toUpperCase(Locale.ENGLISH), Option.OFFLINE.getName(), Arrays.toString(OnlineResource.values())), e);
-                    System.exit(1);
+                    Lifecycle.exitJosm(true, 1);
                     return;
                 }

trunk/src/org/openstreetmap/josm/gui/mappaint/RenderingCLI.java

@@ -39 +39 @@
 import org.openstreetmap.josm.io.IllegalDataException;
 import org.openstreetmap.josm.io.OsmReader;
+import org.openstreetmap.josm.spi.lifecycle.Lifecycle;
 import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.spi.preferences.MemoryPreferences;
@@ -177 +178 @@
             }
             System.err.println(tr("Error - file not found: ''{0}''", e.getMessage()));
-            System.exit(1);
+            Lifecycle.exitJosm(true, 1);
         } catch (IllegalArgumentException | IllegalDataException | IOException e) {
             if (Logging.isDebugEnabled()) {
@@ -185 +186 @@
                 System.err.println(tr("Error: {0}", e.getMessage()));
             }
-            System.exit(1);
-        }
-        System.exit(0);
+            Lifecycle.exitJosm(true, 1);
+        }
+        Lifecycle.exitJosm(true, 0);
     }
 
@@ -228 +229 @@
         case HELP:
             showHelp();
-            System.exit(0);
+            Lifecycle.exitJosm(true, 0);
             break;
         case DEBUG: