Changeset 18315 in josm

Timestamp:

2021-11-07T15:01:40+01:00 (2 years ago)

Author:

Don-vip

Message:

see #21486 - don't try to read int/long/float/double missing GPX metadata

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/gpx/GpxImageEntry.java (modified) (2 diffs)
• tools/ExifReader.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/gpx/GpxImageEntry.java

@@ -732 +732 @@
 
         try {
-            if (dirExif != null) {
+            if (dirExif != null && dirExif.containsTag(ExifIFD0Directory.TAG_ORIENTATION)) {
                 setExifOrientation(dirExif.getInt(ExifIFD0Directory.TAG_ORIENTATION));
             }
@@ -740 +740 @@
 
         try {
-            if (dir != null) {
+            if (dir != null && dir.containsTag(JpegDirectory.TAG_IMAGE_WIDTH) && dir.containsTag(JpegDirectory.TAG_IMAGE_HEIGHT)) {
                 // there are cases where these do not match width and height stored in dirExif
                 setWidth(dir.getInt(JpegDirectory.TAG_IMAGE_WIDTH));

trunk/src/org/openstreetmap/josm/tools/ExifReader.java

@@ -177 +177 @@
      */
     public static LatLon readLatLon(GpsDirectory dirGps) throws MetadataException {
-        if (dirGps != null && dirGps.getTagCount() > 1) {
+        if (dirGps != null && dirGps.containsTag(GpsDirectory.TAG_LATITUDE) && dirGps.containsTag(GpsDirectory.TAG_LONGITUDE)) {
             double lat = readAxis(dirGps, GpsDirectory.TAG_LATITUDE, GpsDirectory.TAG_LATITUDE_REF, 'S');
             double lon = readAxis(dirGps, GpsDirectory.TAG_LONGITUDE, GpsDirectory.TAG_LONGITUDE_REF, 'W');
@@ -297 +297 @@
     public static Double readElevation(File filename) {
         try {
-            final Metadata metadata = JpegMetadataReader.readMetadata(filename);
-            final GpsDirectory dirGps = metadata.getFirstDirectoryOfType(GpsDirectory.class);
-            return readElevation(dirGps);
+            return readElevation(JpegMetadataReader.readMetadata(filename).getFirstDirectoryOfType(GpsDirectory.class));
         } catch (JpegProcessingException | IOException e) {
             Logging.error(e);
-        }
-        return null;
+            return null;
+        }
     }