Changeset 18298 in josm for trunk/src/org

Timestamp:

2021-10-31T20:55:53+01:00 (2 years ago)

Author:

Don-vip

Message:

fix #20927 - ensure divider location remains between 0 and 1

File:

• trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java

@@ -447 +447 @@
         int numRelationDecisions = modelRelConflictResolver.getNumDecisions();
 
-
         if (numTagDecisions > 0 && numRelationDecisions > 0 && getHeight() > 0) {
             // see #12536: Take the space for buttons and checkbox into account.
             double hPopup = getHeight();
-            double h1 = (pnlRelationMemberConflictResolver.getHeight() + pnlTagConflictResolver.getHeight());
-            double correction = h1 > 0 ? ((hPopup-h1)/hPopup) : 0;
+            double h1 = pnlRelationMemberConflictResolver.getHeight() + pnlTagConflictResolver.getHeight();
+            double correction = h1 > 0 && hPopup > h1 ? ((hPopup-h1)/hPopup) : 0;
 
             double nTop = 3.5 + numTagDecisions;
             double nBottom = 5.5 + numRelationDecisions;
-            spTagConflictTypes.setDividerLocation(nTop/(nTop+nBottom) - correction);
+            double ratio = nTop/(nTop+nBottom);
+            spTagConflictTypes.setDividerLocation(ratio > correction ? ratio - correction : ratio);
         }
     }