Changeset 18192 in josm for trunk/src/org

Timestamp:

2021-09-03T02:11:51+02:00 (3 years ago)

Author:

Don-vip

Message:

fix #21279 - fix NPE (patch by marcello, modified)

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompComboBox.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompComboBox.java

@@ -105 +105 @@
         public void insertString(FilterBypass fb, int offset, String string, AttributeSet attr)
                 throws BadLocationException {
-            int newLen = fb.getDocument().getLength() + string.length();
-            if (maxTextLength == -1 || newLen <= maxTextLength ||
-                    // allow longer text while composing characters or it will be hard to compose
-                    // the last characters before the limit
-                    ((attr != null) && attr.isDefined(StyleConstants.ComposedTextAttribute))) {
+            if (mustInsertOrReplace(fb, 0, string, attr)) {
                 super.insertString(fb, offset, string, attr);
             }
@@ -117 +113 @@
         public void replace(FilterBypass fb, int offset, int length, String string, AttributeSet attr)
                 throws BadLocationException {
-            int newLen = fb.getDocument().getLength() - length + string.length();
-            if (maxTextLength == -1 || newLen <= maxTextLength ||
+            if (mustInsertOrReplace(fb, length, string, attr)) {
+                super.replace(fb, offset, length, string, attr);
+            }
+        }
+
+        private boolean mustInsertOrReplace(FilterBypass fb, int length, String string, AttributeSet attr) {
+            int newLen = fb.getDocument().getLength() - length + ((string == null) ? 0 : string.length());
+            return (maxTextLength == -1 || newLen <= maxTextLength ||
                     // allow longer text while composing characters or it will be hard to compose
                     // the last characters before the limit
-                    ((attr != null) && attr.isDefined(StyleConstants.ComposedTextAttribute))) {
-                super.replace(fb, offset, length, string, attr);
-            }
+                    ((attr != null) && attr.isDefined(StyleConstants.ComposedTextAttribute)));
         }
     }