Changeset 18146 in josm

Timestamp:

2021-08-21T00:19:29+02:00 (3 years ago)

Author:

Don-vip

Message:

see #17083 - sign MSI file

Location:

trunk/native

Files:

• macosx/macos-jpackage.sh (modified) (4 diffs)
• windows/win-jpackage.sh (modified) (3 diffs)

trunk/native/macosx/macos-jpackage.sh

@@ -7 +7 @@
 # CERT_MACOS_PW   Password for that certificate
 
-set -Eeou pipefail
+set -Eeo pipefail
 
 # Don't show one time passwords
@@ -28 +28 @@
 then
     echo "CERT_MACOS_P12, CERT_MACOS_PW and APPLE_ID_PW are not set in the environment."
-    echo "I will create a JOSM.app but I won't attempt to sign and notarize it."
+    echo "A JOSM.app will be created but not signed nor notarized."
     SIGNAPP=false
 else
@@ -49 +49 @@
 fi
 
+set -u
+
 if $SIGNAPP; then
   JPACKAGEOPTIONS="--mac-sign --mac-signing-keychain $KEYCHAINPATH"
@@ -56 +58 @@
 
 echo "Building and signing app"
-    jpackage $JPACKAGEOPTIONS -n "JOSM" --input dist --main-jar josm-custom.jar \
+jpackage $JPACKAGEOPTIONS -n "JOSM" --input dist --main-jar josm-custom.jar \
     --main-class org.openstreetmap.josm.gui.MainApplication \
     --icon ./native/macosx/JOSM.icns --type app-image --dest app \

trunk/native/windows/win-jpackage.sh

@@ -1 +1 @@
 #!/bin/bash
 
-set -Eeou pipefail
+## Expected environment, passed from GitHub secrets:
+# https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets
+# SIGN_CERT       PKCS12 certificate keystore used for code signing, base64 encoded
+# SIGN_STOREPASS  Password for that keystore
+# SIGN_TSA        URL of Time Stamping Authority to use
+
+set -Eeo pipefail
 
 # Don't show one time passwords
@@ -16 +22 @@
 mkdir app
 
+if [ -z "$SIGN_CERT" ] || [ -z "$SIGN_STOREPASS" ] || [ -z "$SIGN_TSA" ]
+then
+    echo "SIGN_CERT, SIGN_STOREPASS and SIGN_TSA are not set in the environment."
+    echo "A JOSM.msi will be created but not signed."
+    SIGNAPP=false
+else
+    SIGNAPP=true
+fi
+
+set -u
+
 JPACKAGEOPTIONS=""
 
-echo "Building app"
-    jpackage $JPACKAGEOPTIONS -n "JOSM" --input dist --main-jar josm-custom.jar \
+echo "Building MSI"
+jpackage $JPACKAGEOPTIONS -n "JOSM" --input dist --main-jar josm-custom.jar \
     --main-class org.openstreetmap.josm.gui.MainApplication \
     --icon ./native/windows/logo.ico --type msi --dest app \
@@ -48 +65 @@
 
 echo "Building done."
+
+if $SIGNAPP; then
+    CERTIFICATE_P12=certificate.p12
+    echo "$SIGN_CERT" | base64 --decode > $CERTIFICATE_P12
+    signtool sign //f $CERTIFICATE_P12 //d "Java OpenStreetMap Editor" //du "https://josm.openstreetmap.de" //p "$SIGN_STOREPASS" //v //fd SHA256 //tr "$SIGN_TSA" //td SHA256 "app/JOSM.msi"
+    rm $CERTIFICATE_P12
+fi