Changeset 18129 in josm

Timestamp:

2021-08-09T21:03:05+02:00 (3 years ago)

Author:

Don-vip

Message:

tools update: checkstyle 8.44, spotbugs 4.2.3, proguard 7.1.1, error-prone 2.8.1

Location:

trunk

Files:

• src/org/openstreetmap/josm/actions/mapmode/ParallelWayAction.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetListener.java (modified) (1 diff)
• src/org/openstreetmap/josm/io/MultiFetchServerObjectReader.java (modified) (1 diff)
• src/org/openstreetmap/josm/tools/OsmUrlToBounds.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/io/remotecontrol/handler/RequestHandlerTest.java (modified) (2 diffs)
• tools/checkstyle/META-INF/MANIFEST.MF (modified) (1 diff)
• tools/ivy.xml (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/mapmode/ParallelWayAction.java

@@ -582 +582 @@
         private static Map<Modifier, Boolean> createFromString(String string) {
             Map<Modifier, Boolean> ret = new EnumMap<>(Modifier.class);
-            for (char c : string.toCharArray()) {
+            for (int i = 0; i < string.length(); i++) {
+                char c = string.charAt(i);
                 if (c == '?') {
                     continue;

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetListener.java

@@ -4 +4 @@
 /**
  * Notification of tagging presets events.
+ * @see TaggingPresets#addListener(TaggingPresetListener)
  * @since 7100
- * @see TaggingPresets#addListener(TaggingPresetListener)
  */
 @FunctionalInterface

trunk/src/org/openstreetmap/josm/io/MultiFetchServerObjectReader.java

@@ -373 +373 @@
      * found on  the server (the server response code was 404)
      *
+     * @param progressMonitor progress monitor
      * @return the parsed data
-     * @param progressMonitor progress monitor
      * @throws OsmTransferException if an error occurs while communicating with the API server
      * @see #getMissingPrimitives()

trunk/src/org/openstreetmap/josm/tools/OsmUrlToBounds.java

@@ -174 +174 @@
         int zoomOffset = 0;
 
-        for (final char ch : shortLink.toCharArray()) {
+        for (int j = 0; j < shortLink.length(); j++) {
+            char ch = shortLink.charAt(j);
             if (array.containsKey(ch)) {
                 int val = array.get(ch);

trunk/test/unit/org/openstreetmap/josm/io/remotecontrol/handler/RequestHandlerTest.java

@@ -9 +9 @@
 import java.util.Map;
 
+import org.junit.jupiter.api.Test;
 import org.openstreetmap.josm.io.remotecontrol.PermissionPrefWithDefault;
 import org.openstreetmap.josm.io.remotecontrol.handler.RequestHandler.RequestHandlerBadRequestException;
-
-import org.junit.jupiter.api.Test;
 
 /**
@@ -81 +80 @@
     /**
      * Test request parameter - case 4
-     * @see <a href="http://blog.lunatech.com/2009/02/03/what-every-web-developer-must-know-about-url-encoding">
+     * @throws RequestHandlerBadRequestException never
+     * @see <a href="https://www.talisman.org/~erlkonig/misc/lunatech%5Ewhat-every-webdev-must-know-about-url-encoding/">
      *      What every web developer must know about URL encoding</a>
-     * @throws RequestHandlerBadRequestException never
      */
     @Test

trunk/tools/checkstyle/META-INF/MANIFEST.MF

@@ -3 +3 @@
 Bundle-Name: JOSM Checkstyle Eclipse Plugin
 Bundle-SymbolicName: org.openstreetmap.josm.checkstyle-eclipse-plugin;singleton:=true
-Bundle-Version: 8.43.0.qualifier
+Bundle-Version: 8.44.0.qualifier
 Require-Bundle: net.sf.eclipsecs.checkstyle,
  net.sf.eclipsecs.core,

trunk/tools/ivy.xml

@@ -17 +17 @@
         <dependency org="net.java.dev.javacc" name="javacc" rev="7.0.10" conf="javacc->default"/>
         <!-- checkstyle->default -->
-        <dependency org="com.puppycrawl.tools" name="checkstyle" rev="8.43" conf="checkstyle->default"/>
+        <dependency org="com.puppycrawl.tools" name="checkstyle" rev="8.44" conf="checkstyle->default"/>
         <!-- proguard->default -->
-        <dependency org="com.guardsquare" name="proguard-ant" rev="7.1.0" conf="proguard->default"/>
+        <dependency org="com.guardsquare" name="proguard-ant" rev="7.1.1" conf="proguard->default"/>
         <!-- pmd->default -->
         <dependency org="net.sourceforge.pmd" name="pmd-core" rev="6.20.0" conf="pmd->default"/>
@@ -28 +28 @@
         </dependency>
         <!-- spotbugs->default -->
-        <dependency org="com.github.spotbugs" name="spotbugs" rev="4.2.1" conf="spotbugs->default"/>
-        <dependency org="com.github.spotbugs" name="spotbugs-ant" rev="4.2.1" conf="spotbugs->default"/>
+        <dependency org="com.github.spotbugs" name="spotbugs" rev="4.2.3" conf="spotbugs->default"/>
+        <dependency org="com.github.spotbugs" name="spotbugs-ant" rev="4.2.3" conf="spotbugs->default"/>
         <!-- errorprone->default -->
-        <dependency org="com.google.errorprone" name="error_prone_core" rev="2.7.1" conf="errorprone->default"/>
+        <dependency org="com.google.errorprone" name="error_prone_core" rev="2.8.1" conf="errorprone->default"/>
         <!-- errorprone->default -->
         <dependency org="com.google.errorprone" name="javac" rev="9+181-r4173-1" conf="errorprone_javac->default"/>