Changeset 17857 in josm

Timestamp:

2021-05-03T14:04:46+02:00 (4 years ago)

Author:

Don-vip

Message:

improve PluginHandlerTestIT assertions readability

File:

• trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerTestIT.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerTestIT.java

@@ -53 +53 @@
     @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
     public static JOSMTestRules test = new JOSMTestRules().main().projection().preferences().https()
-            .timeout(10 * 60 * 1000);
+            .territories().timeout(10 * 60 * 1000);
 
     /**
@@ -106 +106 @@
         noRestartExceptions = filterKnownErrors(noRestartExceptions);
 
-        String msg = Arrays.toString(invalidManifestEntries.entrySet().toArray()) + '\n' +
-                     Arrays.toString(loadingExceptions.entrySet().toArray()) + '\n' +
-                Arrays.toString(layerExceptions.entrySet().toArray()) + '\n'
-                + Arrays.toString(noRestartExceptions.entrySet().toArray());
-        assertTrue(invalidManifestEntries.isEmpty() && loadingExceptions.isEmpty() && layerExceptions.isEmpty(), msg);
+        String msg = errMsg("invalidManifestEntries", invalidManifestEntries) + '\n' +
+                errMsg("loadingExceptions", loadingExceptions) + '\n' +
+                errMsg("layerExceptions", layerExceptions) + '\n' +
+                errMsg("noRestartExceptions", noRestartExceptions);
+        assertTrue(invalidManifestEntries.isEmpty()
+                && loadingExceptions.isEmpty()
+                && layerExceptions.isEmpty()
+                && noRestartExceptions.isEmpty(), msg);
+    }
+
+    private static String errMsg(String type, Map<String, ?> map) {
+        return type + ": " + Arrays.toString(map.entrySet().toArray());
     }