Changeset 17793 in josm for trunk/src/org

Timestamp:

2021-04-19T19:03:32+02:00 (5 years ago)

Author:

simon04

Message:

Fix PMD Warnings

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/ShowStatusReportAction.java (modified) (2 diffs)
• gui/MainApplication.java (modified) (1 diff)
• gui/layer/geoimage/ImageDisplay.java (modified) (1 diff)
• gui/mappaint/DividedScale.java (modified) (1 diff)
• gui/preferences/plugin/PluginListPanel.java (modified) (2 diffs)
• gui/tagging/presets/items/Text.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/ShowStatusReportAction.java

@@ -130 +130 @@
 
         for (String name : Arrays.asList("LANG", "LC_ALL")) {
-            String value = Utils.getSystemEnv(name);
+            String value = getSystemEnv(name);
             if (value != null) {
                 text.format("Environment variable %s: %s%n", name, value);
@@ -136 +136 @@
         }
         for (String name : Arrays.asList("file.encoding", "sun.jnu.encoding")) {
-            String value = Utils.getSystemProperty(name);
+            String value = getSystemProperty(name);
             if (value != null) {
                 text.format("System property %s: %s%n", name, value);

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -370 +370 @@
      */
     public static void askUpdateJava(String updVersion, String url, String eolDate, boolean major) {
-        StringBuilder content = new StringBuilder(tr("You are running version {0} of Java.",
+        StringBuilder content = new StringBuilder(256);
+        content.append(tr("You are running version {0} of Java.",
                 "<b>"+getSystemProperty("java.version")+"</b>")).append("<br><br>");
         if ("Sun Microsystems Inc.".equals(getSystemProperty("java.vendor")) && !PlatformManager.getPlatform().isOpenJDK()) {

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageDisplay.java

@@ -1013 +1013 @@
     public void zoomBestFitOrOne() {
         ImageEntry entry;
-        ImageEntry oldEntry;
         Image image;
         VisRect visibleRect;

trunk/src/org/openstreetmap/josm/gui/mappaint/DividedScale.java

@@ -156 +156 @@
      */
     public void consistencyTest() {
-        if (ranges.size() < 1) throw new AssertionError(ranges);
+        if (ranges.isEmpty()) throw new AssertionError(ranges);
         if (data.isEmpty()) throw new AssertionError(data);
         if (ranges.size() != data.size()) throw new AssertionError();

trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginListPanel.java

@@ -10 +10 @@
 import java.awt.event.MouseAdapter;
 import java.awt.event.MouseEvent;
-import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
@@ -44 +43 @@
 
     /** Whether the plugin list has been built up already in the UI. */
-    private boolean pluginListInitialized = false;
+    private boolean pluginListInitialized;
 
     /**

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Text.java

@@ -239 +239 @@
     }
 
-    public void setValue_template(String pattern) throws SAXException {
+    public void setValue_template(String pattern) throws SAXException { // NOPMD
         try {
             this.valueTemplate = new TemplateParser(pattern).parse();
@@ -250 +250 @@
     private void setupListeners(AutoCompletingTextField textField, TaggingPresetItemGuiSupport support) {
         textField.getDocument().addDocumentListener(DocumentAdapter.create(ignore ->
-                support.fireItemValueModified(Text.this, key, textField.getText())));
+                support.fireItemValueModified(this, key, textField.getText())));
 
         if (valueTemplate != null) {