Changeset 17785 in josm

Timestamp:

2021-04-14T21:21:33+02:00 (3 years ago)

Author:

simon04

Message:

see #20720 - Filtering in plugins list in preferences is slow (simplify)

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginListPanel.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginListPanel.java

@@ -10 +10 @@
 import java.awt.event.MouseAdapter;
 import java.awt.event.MouseEvent;
-import java.util.ArrayList;
+import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
@@ -113 +113 @@
         );
         hint.putClientProperty("plugin", "empty");
+        hint.setVisible(false);
         add(hint, gbc);
     }
@@ -170 +171 @@
             add(description, gbc);
         }
-
         pluginListInitialized = true;
     }
@@ -182 +182 @@
     public void refreshView() {
         final Rectangle visibleRect = getVisibleRect();
-        List<PluginInformation> displayedPlugins = model.getDisplayedPlugins();
-
-        if (displayedPlugins.isEmpty()) {
-            hidePluginsNotInList(new ArrayList<>());
+        if (!pluginListInitialized) {
+            removeAll();
             displayEmptyPluginListInformation();
-        } else if (!pluginListInitialized) {
-            removeAll();
-            displayPluginList(displayedPlugins);
+            displayPluginList(model.getAvailablePlugins());
         } else {
-            hidePluginsNotInList(displayedPlugins);
+            hidePluginsNotInList(new HashSet<>(model.getDisplayedPlugins()));
         }
         revalidate();
@@ -205 +201 @@
      * those that shouldn't be visible.
      *
-     * @param displayedPlugins A collection of plugins that are currently visible.
-     */
-    private void hidePluginsNotInList(List<PluginInformation> displayedPlugins) {
-        // Remove the empty plugin list warning if it's there
-        synchronized (getTreeLock()) {
-            for (int i = 0; i < getComponentCount(); i++) {
-                JComponent component = (JComponent) getComponent(i);
-                if ("empty".equals(component.getClientProperty("plugin"))) {
-                    remove(component);
-                }
-            }
-        }
-
-        Set<PluginInformation> displayedPluginsSet = new HashSet<>(displayedPlugins);
+     * @param displayedPlugins A set of plugins that are currently visible.
+     */
+    private void hidePluginsNotInList(Set<PluginInformation> displayedPlugins) {
         synchronized (getTreeLock()) {
             for (int i = 0; i < getComponentCount(); i++) {
                 JComponent component = (JComponent) getComponent(i);
                 Object plugin = component.getClientProperty("plugin");
-                component.setVisible(displayedPluginsSet.contains(plugin));
+                if ("empty".equals(plugin)) {
+                    // Hide the empty plugin list warning if it's there
+                    component.setVisible(displayedPlugins.isEmpty());
+                } else {
+                    component.setVisible(displayedPlugins.contains(plugin));
+                }
             }
         }