Changeset 17595 in josm

Timestamp:

2021-03-20T12:24:12+01:00 (3 years ago)

Author:

simon04

Message:

see #20047 - Use TagModel.getValue; use String.join

Location:

trunk/src/org/openstreetmap/josm/gui/tagging

Files:

• TagCellEditor.java (modified) (1 diff)
• TagCellRenderer.java (modified) (1 diff)
• TagModel.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/tagging/TagCellEditor.java

@@ -105 +105 @@
         } else if (column == 1) {
 
-            if (currentTag.getValueCount() == 0) {
+            if (currentTag.getValueCount() > 1) {
                 editor.setText("");
-            } else if (currentTag.getValueCount() == 1) {
-                editor.setText(currentTag.getValues().get(0));
             } else {
-                editor.setText("");
+                editor.setText(currentTag.getValue());
             }
             initAutoCompletionListForValues(currentTag.getName());

trunk/src/org/openstreetmap/josm/gui/tagging/TagCellRenderer.java

@@ -52 +52 @@
      */
     protected void renderTagValue(TagModel tag) {
-        if (tag.getValueCount() == 0) {
-            setText("");
-        } else if (tag.getValueCount() == 1) {
-            setText(tag.getValues().get(0));
-        } else if (tag.getValueCount() > 1) {
+        if (tag.getValueCount() > 1) {
             setText(tr("multiple"));
             setFont(fontItalic);
+        } else {
+            setText(tag.getValue());
         }
     }

trunk/src/org/openstreetmap/josm/gui/tagging/TagModel.java

@@ -126 +126 @@
             return values.get(0);
         } else {
-            StringBuilder sb = new StringBuilder();
-            for (int i = 0; i < values.size(); i++) {
-                sb.append(values.get(i));
-                if (i + 1 < values.size()) {
-                    sb.append(';');
-                }
-            }
-            return sb.toString();
+            return String.join(";", values);
         }
     }