Changeset 17353 in josm for trunk

Timestamp:

2020-11-24T15:20:53+01:00 (3 years ago)

Author:

GerdP

Message:

fix #12536: Conflict window completely hides relation 'conflicts' while doing a "Replace Geometry"

• improve calculation of divider location

When resizing the dialog the refreshed result is still poor but I hope that's less annoying.

File:

• trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java

@@ -344 +344 @@
 
         getContentPane().add(pnlButtons, BorderLayout.SOUTH);
-        validate();
+        getContentPane().validate();
         adjustDividerLocation();
         pnlRelationMemberConflictResolver.prepareForEditing();
@@ -445 +445 @@
         int numTagDecisions = modelTagConflictResolver.getNumDecisions();
         int numRelationDecisions = modelRelConflictResolver.getNumDecisions();
-        if (numTagDecisions > 0 && numRelationDecisions > 0) {
-            double nTop = 1.0 + numTagDecisions;
-            double nBottom = 2.5 + numRelationDecisions;
-            spTagConflictTypes.setDividerLocation(nTop/(nTop+nBottom));
+
+
+        if (numTagDecisions > 0 && numRelationDecisions > 0 && getHeight() > 0) {
+            // see #12536: Take the space for buttons and checkbox into account.
+            double hPopup = getHeight();
+            double h1 = (pnlRelationMemberConflictResolver.getHeight() + pnlTagConflictResolver.getHeight());
+            double correction = h1 > 0 ? ((hPopup-h1)/hPopup) : 0;
+
+            double nTop = 3.5 + numTagDecisions;
+            double nBottom = 5.5 + numRelationDecisions;
+            spTagConflictTypes.setDividerLocation(nTop/(nTop+nBottom) - correction);
         }
     }