Changeset 16623 in josm for trunk/src

Timestamp:

2020-06-14T14:55:16+02:00 (5 years ago)

Author:

simon04

Message:

see #19334 - ​https://errorprone.info/bugpattern/StaticAssignmentInConstructor

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/MainApplication.java (modified) (1 diff)
• gui/bbox/SlippyMapBBoxChooser.java (modified) (1 diff)
• io/audio/AudioPlayer.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/MainApplication.java ¶

@@ -330 +330 @@
      * @since 10340
      */
+    @SuppressWarnings("StaticAssignmentInConstructor")
     public MainApplication(MainFrame mainFrame) {
         MainApplication.mainFrame = mainFrame;

trunk/src/org/openstreetmap/josm/gui/bbox/SlippyMapBBoxChooser.java ¶

@@ -82 +82 @@
     private transient ICoordinate iSelectionRectEnd;
 
+    static {
+        debug = Logging.isDebugEnabled();
+    }
+
     /**
      * Constructs a new {@code SlippyMapBBoxChooser}.
      */
     public SlippyMapBBoxChooser() {
-        debug = Logging.isDebugEnabled();
         SpringLayout springLayout = new SpringLayout();
         setLayout(springLayout);

trunk/src/org/openstreetmap/josm/io/audio/AudioPlayer.java ¶

@@ -268 +268 @@
     }
 
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings({"unchecked", "StaticAssignmentInConstructor"})
     private AudioPlayer() {
         state = State.INITIALIZING;