Changeset 16567 in josm

Timestamp:

2020-06-07T22:46:53+02:00 (4 years ago)

Author:

simon04

Message:

fix #19354 - UndoRedoHandler.getUndoCommands: return unmodifiable list

File:

• trunk/src/org/openstreetmap/josm/data/UndoRedoHandler.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/UndoRedoHandler.java

@@ -2 +2 @@
 package org.openstreetmap.josm.data;
 
+import java.util.Collections;
 import java.util.EventObject;
 import java.util.LinkedList;
@@ -238 +239 @@
      * Returns all commands that were made on the dataset, that can be undone.
      * @return all commands that were made on the dataset, that can be undone
-     * @since 14281
-     */
-    public LinkedList<Command> getUndoCommands() {
-        return new LinkedList<>(commands);
+     * @since 14281, 16567 (signature)
+     */
+    public List<Command> getUndoCommands() {
+        return Collections.unmodifiableList(commands);
     }
 
@@ -247 +248 @@
      * Returns all commands that were made and undone on the dataset, that can be redone.
      * @return all commands that were made and undone on the dataset, that can be redone.
-     * @since 14281
-     */
-    public LinkedList<Command> getRedoCommands() {
-        return new LinkedList<>(redoCommands);
+     * @since 14281, 16567 (signature)
+     */
+    public List<Command> getRedoCommands() {
+        return Collections.unmodifiableList(redoCommands);
     }