Changeset 1642 in josm

Timestamp:

2009-06-06T16:25:25+02:00 (15 years ago)

Author:

Gubaer

Message:

added row numbers and synchronized scrolling in conflict resolution dialog
fixed bugs in conflict resolution

Location:

trunk/src/org/openstreetmap/josm

Files:

• command/TagConflictResolveCommand.java (modified) (7 diffs)
• command/VersionConflictResolveCommand.java (modified) (4 diffs)
• gui/conflict/ConflictResolver.java (modified) (1 diff)
• gui/conflict/ListMergeModel.java (modified) (10 diffs)
• gui/conflict/ListMerger.java (modified) (13 diffs)
• gui/conflict/nodes/NodeListColumnModel.java (modified) (1 diff)
• gui/conflict/nodes/NodeListMerger.java (modified) (3 diffs)
• gui/conflict/nodes/NodeListTableCellRenderer.java (modified) (4 diffs)
• gui/conflict/relation/RelationMemberListColumnModel.java (modified) (1 diff)
• gui/conflict/relation/RelationMemberListMergeModel.java (modified) (2 diffs)
• gui/conflict/relation/RelationMemberMerger.java (modified) (4 diffs)
• gui/conflict/relation/RelationMemberTableCellRenderer.java (modified) (7 diffs)
• gui/conflict/tags/MergedTableCellRenderer.java (moved) (moved from trunk/src/org/openstreetmap/josm/gui/conflict/tags/UndecidedTableCellRenderer.java ) (1 diff)
• gui/conflict/tags/TagMerger.java (modified) (13 diffs)
• gui/dialogs/ConflictDialog.java (modified) (10 diffs)
• gui/dialogs/ConflictResolutionDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/command/TagConflictResolveCommand.java

@@ -25 +25 @@
  */
 public class TagConflictResolveCommand extends Command {
-    
+
     /** my primitive (in the local dataset). merge decisions are applied to this
      *  primitive
      */
-    private OsmPrimitive my;
-    /** their primitive (in the server dataset) */ 
-    private OsmPrimitive their;
-    
+    private final OsmPrimitive my;
+    /** their primitive (in the server dataset) */
+    private final OsmPrimitive their;
+
     /** the list of merge decisions, represented as {@see TagMergeItem}s */
-    private List<TagMergeItem> mergeItems; 
-    
+    private final List<TagMergeItem> mergeItems;
+
     /**
      * replies the number of decided conflicts
      * 
-     * @return the number of decided conflicts 
+     * @return the number of decided conflicts
      */
     public int getNumDecidedConflicts() {
@@ -45 +45 @@
         for (TagMergeItem item: mergeItems) {
             if (!item.getMergeDecision().equals(MergeDecisionType.UNDECIDED)) {
-                n++; 
+                n++;
             }
         }
         return n;
     }
-    
+
     /**
      * replies a (localized) display name for the type of an OSM primitive
@@ -63 +63 @@
         return "";
     }
-    
+
     /**
-     * constructor 
+     * constructor
      * 
      * @param my  my primitive
-     * @param their  their primitive 
+     * @param their  their primitive
      * @param mergeItems the list of merge decisions, represented as {@see TagMergeItem}s
      */
@@ -76 +76 @@
         this.mergeItems = mergeItems;
     }
-    
-    
+
+
     @Override
-    public MutableTreeNode description() {                
+    public MutableTreeNode description() {
         return new DefaultMutableTreeNode(
-          new JLabel(
-             tr("Resolve {0} tag conflicts in {1} {2}",getNumDecidedConflicts(), getPrimitiveTypeAsString(my), my.id), 
-             ImageProvider.get("data", "object"), 
-             JLabel.HORIZONTAL
-          )
-       );
+                new JLabel(
+                        tr("Resolve {0} tag conflicts in {1} {2}",getNumDecidedConflicts(), getPrimitiveTypeAsString(my), my.id),
+                        ImageProvider.get("data", "object"),
+                        JLabel.HORIZONTAL
+                )
+        );
     }
 
@@ -95 +95 @@
         //
         super.executeCommand();
-        
+
         // apply the merge decisions to OSM primitive 'my'
         //
         for (TagMergeItem item: mergeItems) {
-            item.applyToMyPrimitive(my);
+            if (! item.getMergeDecision().equals(MergeDecisionType.UNDECIDED)) {
+                item.applyToMyPrimitive(my);
+            }
         }
         return true;
@@ -115 +117 @@
         //
         super.undoCommand();
-        
+
         // restore a conflict if necessary
         //
@@ -123 +125 @@
     }
 
-    
+
 }

trunk/src/org/openstreetmap/josm/command/VersionConflictResolveCommand.java

@@ -24 +24 @@
 public class VersionConflictResolveCommand extends Command {
 
-    private OsmPrimitive my;
-    private OsmPrimitive their;
-    
+    private final OsmPrimitive my;
+    private final OsmPrimitive their;
+
     /**
-     * constructor 
-     * @param my  my primitive (i.e. the primitive from the local dataset) 
-     * @param their their primitive (i.e. the primitive from the server) 
+     * constructor
+     * @param my  my primitive (i.e. the primitive from the local dataset)
+     * @param their their primitive (i.e. the primitive from the server)
      */
     public VersionConflictResolveCommand(OsmPrimitive my, OsmPrimitive their) {
-      this.my = my;
-      this.their = their; 
+        this.my = my;
+        this.their = their;
     }
-    
+
     //FIXME copied from TagConflictResolveCommand -> refactor
     /**
@@ -50 +50 @@
         return "";
     }
-    
+
     @Override
     public MutableTreeNode description() {
         return new DefaultMutableTreeNode(
-            new JLabel(
-               tr("Resolve version conflicts for {0} {1}",getPrimitiveTypeAsString(my), my.id), 
-               ImageProvider.get("data", "object"), 
-               JLabel.HORIZONTAL
-            )
-         );
+                new JLabel(
+                        tr("Resolve version conflicts for {0} {1}",getPrimitiveTypeAsString(my), my.id),
+                        ImageProvider.get("data", "object"),
+                        JLabel.HORIZONTAL
+                )
+        );
     }
 
@@ -66 +66 @@
         super.executeCommand();
         my.version = Math.max(my.version, their.version);
-        Main.map.conflictDialog.conflicts.remove(my);
+        Main.map.conflictDialog.removeConflictForPrimitive(my);
         return true;
     }
@@ -79 +79 @@
     public void undoCommand() {
         super.undoCommand();
-        
+
         // restore a conflict if necessary
         //
         if (!Main.map.conflictDialog.conflicts.containsKey(my)) {
-            Main.map.conflictDialog.conflicts.put(my,their);
+            Main.map.conflictDialog.addConflict(my, their);
         }
     }
 
-    
+
 }

trunk/src/org/openstreetmap/josm/gui/conflict/ConflictResolver.java

@@ -189 +189 @@
             }
         }
-
         return new SequenceCommand(tr("Conflict Resolution"), commands);
     }
+
+    public boolean isCompletelyResolved() {
+        if (my instanceof Node) {
+            // resolve the version conflict if this is a node and all tag
+            // conflicts have been resolved
+            //
+            if (tagMerger.getModel().isResolvedCompletely())
+                return true;
+        } else if (my instanceof Way) {
+            // resolve the version conflict if this is a way, all tag
+            // conflicts have been resolved, and conflicts in the node list
+            // have been resolved
+            //
+            if (tagMerger.getModel().isResolvedCompletely() && nodeListMerger.getModel().isFrozen())
+                return true;
+        }  else if (my instanceof Relation) {
+            // resolve the version conflict if this is a relation, all tag
+            // conflicts and all conflicts in the member list
+            // have been resolved
+            //
+            if (tagMerger.getModel().isResolvedCompletely() && relationMemberMerger.getModel().isFrozen())
+                return true;
+        }
+        return false;
+    }
 }

trunk/src/org/openstreetmap/josm/gui/conflict/ListMergeModel.java

@@ -11 +11 @@
 
 import javax.swing.DefaultListSelectionModel;
-import javax.swing.ListSelectionModel;
 import javax.swing.table.DefaultTableModel;
 import javax.swing.table.TableModel;
@@ -35 +34 @@
  * {@see #PROP_FROZEN}.
  * 
- * ListMergeModel is an abstract class. There methods have to be implemented by subclasses:
+ * ListMergeModel is an abstract class. Three methods have to be implemented by subclasses:
  * <ul>
  *   <li>{@see ListMergeModel#cloneEntry(Object)} - clones an entry of type T</li>
@@ -61 +60 @@
     protected DefaultTableModel mergedEntriesTableModel;
 
-    protected DefaultListSelectionModel myEntriesSelectionModel;
-    protected DefaultListSelectionModel theirEntriesSelectionModel;
-    protected DefaultListSelectionModel mergedEntriesSelectionModel;
+    protected EntriesSelectionModel<T> myEntriesSelectionModel;
+    protected EntriesSelectionModel<T> theirEntriesSelectionModel;
+    protected EntriesSelectionModel<T> mergedEntriesSelectionModel;
 
     private final ArrayList<PropertyChangeListener> listeners;
@@ -100 +99 @@
 
     protected void buildMyEntriesTableModel() {
-        myEntriesTableModel = new ListTableModel<T>(myEntries);
+        myEntriesTableModel = new EntriesTableModel<T>(myEntries);
     }
 
     protected void buildTheirEntriesTableModel() {
-        theirEntriesTableModel = new ListTableModel<T>(theirEntries);
+        theirEntriesTableModel = new EntriesTableModel<T>(theirEntries);
     }
 
     protected void buildMergedEntriesTableModel() {
-        mergedEntriesTableModel = new ListTableModel<T>(mergedEntries);
+        mergedEntriesTableModel = new EntriesTableModel<T>(mergedEntries);
     }
 
@@ -120 +119 @@
         buildMergedEntriesTableModel();
 
-        myEntriesSelectionModel = new DefaultListSelectionModel();
-        theirEntriesSelectionModel = new DefaultListSelectionModel();
-        mergedEntriesSelectionModel = new DefaultListSelectionModel();
+        myEntriesSelectionModel = new EntriesSelectionModel<T>(myEntries);
+        theirEntriesSelectionModel = new EntriesSelectionModel<T>(theirEntries);
+        mergedEntriesSelectionModel =  new EntriesSelectionModel<T>(mergedEntries);
 
         listeners = new ArrayList<PropertyChangeListener>();
@@ -177 +176 @@
     }
 
-    public ListSelectionModel getMySelectionModel() {
+    public EntriesSelectionModel getMySelectionModel() {
         return myEntriesSelectionModel;
     }
 
-    public ListSelectionModel getTheirSelectionModel() {
+    public EntriesSelectionModel getTheirSelectionModel() {
         return theirEntriesSelectionModel;
     }
 
-    public ListSelectionModel getMergedSelectionModel() {
+    public EntriesSelectionModel getMergedSelectionModel() {
         return mergedEntriesSelectionModel;
     }
@@ -339 +338 @@
             throw new IllegalArgumentException(tr("parameter current out of range: got {0}", current));
         if (current == mergedEntries.size() -1) {
-            copyMyToEnd(rows);
+            if (source == myEntries) {
+                copyMyToEnd(rows);
+            } else if (source == theirEntries) {
+                copyTheirToEnd(rows);
+            }
         } else {
             for (int i=rows.length -1; i>=0; i--) {
@@ -461 +464 @@
 
 
-
-    protected class ListTableModel<T> extends DefaultTableModel {
-        private final ArrayList<T> entries;
-
-        public ListTableModel(ArrayList<T> nodes) {
+    protected class EntriesTableModel<T1> extends DefaultTableModel {
+        private final ArrayList<T1> entries;
+
+        public EntriesTableModel(ArrayList<T1> nodes) {
             this.entries = nodes;
         }
@@ -471 +473 @@
         @Override
         public int getRowCount() {
-            return entries == null ? 0 : entries.size();
+            int count = myEntries.size();
+            count = Math.max(count, mergedEntries.size());
+            count = Math.max(count, theirEntries.size());
+            return count;
         }
 
         @Override
         public Object getValueAt(int row, int column) {
-            return entries.get(row);
+            if (row < entries.size())
+                return entries.get(row);
+            return null;
         }
 
@@ -490 +497 @@
     }
 
-
-
+    protected class EntriesSelectionModel<T1> extends DefaultListSelectionModel {
+        private final ArrayList<T1> entries;
+
+        public EntriesSelectionModel(ArrayList<T1> nodes) {
+            this.entries = nodes;
+        }
+
+        @Override
+        public void addSelectionInterval(int index0, int index1) {
+            if (entries.isEmpty()) return;
+            if (index0 > entries.size() - 1) return;
+            index0 = Math.min(entries.size()-1, index0);
+            index1 = Math.min(entries.size()-1, index1);
+            super.addSelectionInterval(index0, index1);
+        }
+
+        @Override
+        public void insertIndexInterval(int index, int length, boolean before) {
+            if (entries.isEmpty()) return;
+            if (before) {
+                int newindex = Math.min(entries.size()-1, index);
+                if (newindex < index - length) return;
+                length = length - (index - newindex);
+                super.insertIndexInterval(newindex, length, before);
+            } else {
+                if (index > entries.size() -1) return;
+                length = Math.min(entries.size()-1 - index, length);
+                super.insertIndexInterval(index, length, before);
+            }
+        }
+
+        @Override
+        public void moveLeadSelectionIndex(int leadIndex) {
+            if (entries.isEmpty()) return;
+            leadIndex = Math.max(0, leadIndex);
+            leadIndex = Math.min(entries.size() - 1, leadIndex);
+            super.moveLeadSelectionIndex(leadIndex);
+        }
+
+        @Override
+        public void removeIndexInterval(int index0, int index1) {
+            if (entries.isEmpty()) return;
+            index0 = Math.max(0, index0);
+            index0 = Math.min(entries.size() - 1, index0);
+
+            index1 = Math.max(0, index1);
+            index1 = Math.min(entries.size() - 1, index1);
+            super.removeIndexInterval(index0, index1);
+        }
+
+        @Override
+        public void removeSelectionInterval(int index0, int index1) {
+            if (entries.isEmpty()) return;
+            index0 = Math.max(0, index0);
+            index0 = Math.min(entries.size() - 1, index0);
+
+            index1 = Math.max(0, index1);
+            index1 = Math.min(entries.size() - 1, index1);
+            super.removeSelectionInterval(index0, index1);
+        }
+
+        @Override
+        public void setAnchorSelectionIndex(int anchorIndex) {
+            if (entries.isEmpty()) return;
+            anchorIndex = Math.min(entries.size() - 1, anchorIndex);
+            super.setAnchorSelectionIndex(anchorIndex);
+        }
+
+        @Override
+        public void setLeadSelectionIndex(int leadIndex) {
+            if (entries.isEmpty()) return;
+            leadIndex = Math.min(entries.size() - 1, leadIndex);
+            super.setLeadSelectionIndex(leadIndex);
+        }
+
+        @Override
+        public void setSelectionInterval(int index0, int index1) {
+            if (entries.isEmpty()) return;
+            index0 = Math.max(0, index0);
+            index0 = Math.min(entries.size() - 1, index0);
+
+            index1 = Math.max(0, index1);
+            index1 = Math.min(entries.size() - 1, index1);
+
+            super.setSelectionInterval(index0, index1);
+        }
+    }
 }

trunk/src/org/openstreetmap/josm/gui/conflict/ListMerger.java

@@ -3 +3 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
+import java.awt.Adjustable;
+import java.awt.FlowLayout;
 import java.awt.GridBagConstraints;
 import java.awt.GridBagLayout;
 import java.awt.Insets;
 import java.awt.event.ActionEvent;
+import java.awt.event.AdjustmentEvent;
+import java.awt.event.AdjustmentListener;
 import java.awt.event.ItemEvent;
 import java.awt.event.ItemListener;
 import java.beans.PropertyChangeEvent;
 import java.beans.PropertyChangeListener;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Observable;
+import java.util.Observer;
 import java.util.logging.Logger;
 
@@ -17 +25 @@
 import javax.swing.ImageIcon;
 import javax.swing.JButton;
+import javax.swing.JCheckBox;
 import javax.swing.JLabel;
 import javax.swing.JPanel;
@@ -58 +67 @@
     private FreezeAction freezeAction;
 
-
+    private AdjustmentSynchronizer adjustmentSynchronizer;
+
+    private  JCheckBox cbLockMyScrolling;
+    private  JCheckBox cbLockMergedScrolling;
+    private  JCheckBox cbLockTheirScrolling;
+
+    abstract protected JScrollPane buildMyElementsTable();
+    abstract protected JScrollPane buildMergedElementsTable();
+    abstract protected JScrollPane buildTheirElementsTable();
 
     protected JScrollPane embeddInScrollPane(JTable table) {
@@ -64 +81 @@
         pane.setHorizontalScrollBarPolicy(JScrollPane.HORIZONTAL_SCROLLBAR_AS_NEEDED);
         pane.setVerticalScrollBarPolicy(JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED);
+        if (adjustmentSynchronizer == null) {
+            adjustmentSynchronizer = new AdjustmentSynchronizer();
+        }
         return pane;
     }
-
-    abstract protected JScrollPane buildMyElementsTable();
-    abstract protected JScrollPane buildMergedElementsTable();
-    abstract protected JScrollPane buildTheirElementsTable();
-
-
 
     protected void wireActionsToSelectionModels() {
@@ -99 +113 @@
         mergedEntriesTable.getSelectionModel().addListSelectionListener(removeMergedAction);
     }
-
-
 
     protected JPanel buildLeftButtonPanel() {
@@ -206 +218 @@
     }
 
+    protected JPanel buildAdjustmentLockControlPanel(JCheckBox cb) {
+        JPanel panel = new JPanel();
+        panel.setLayout(new FlowLayout(FlowLayout.RIGHT));
+        panel.add(new JLabel(tr("lock scrolling")));
+        panel.add(cb);
+        return panel;
+    }
+
     protected void build() {
         setLayout(new GridBagLayout());
         GridBagConstraints gc = new GridBagConstraints();
 
+        // ------------------
         gc.gridx = 0;
         gc.gridy = 0;
@@ -225 +246 @@
         gc.gridx = 2;
         gc.gridy = 0;
-        gc.gridwidth = 1;
-        gc.gridheight = 1;
-        gc.fill = GridBagConstraints.NONE;
-        gc.anchor = GridBagConstraints.CENTER;
-        gc.weightx = 0.0;
-        gc.weighty = 0.0;
         lbl = new JLabel(tr("Merged version"));
         lbl.setToolTipText(tr("List of merged elements. They will replace the my elements when the merge decisions are applied."));
@@ -237 +252 @@
         gc.gridx = 4;
         gc.gridy = 0;
+        lbl = new JLabel(tr("Their version"));
+        lbl.setToolTipText(tr("List of elements in their dataset, i.e. the server dataset"));
+        add(lbl, gc);
+
+        // ------------------------------
+        gc.gridx = 0;
+        gc.gridy = 1;
         gc.gridwidth = 1;
         gc.gridheight = 1;
-        gc.fill = GridBagConstraints.NONE;
-        gc.anchor = GridBagConstraints.CENTER;
-        gc.weightx = 0.0;
+        gc.fill = GridBagConstraints.HORIZONTAL;
+        gc.anchor = GridBagConstraints.FIRST_LINE_START;
+        gc.weightx = 0.33;
         gc.weighty = 0.0;
-        lbl = new JLabel(tr("Their version"));
-        lbl.setToolTipText(tr("List of elements in their dataset, i.e. the server dataset"));
-
-        add(lbl, gc);
-
-        gc.gridx = 0;
+        gc.insets = new Insets(0,0,0,0);
+        cbLockMyScrolling = new JCheckBox();
+        cbLockMyScrolling.setName("checkbox.lockmyscrolling");
+        add(buildAdjustmentLockControlPanel(cbLockMyScrolling), gc);
+
+        gc.gridx = 2;
         gc.gridy = 1;
+        cbLockMergedScrolling = new JCheckBox();
+        cbLockMergedScrolling.setName("checkbox.lockmergedscrolling");
+        add(buildAdjustmentLockControlPanel(cbLockMergedScrolling), gc);
+
+        gc.gridx = 4;
+        gc.gridy = 1;
+        cbLockTheirScrolling = new JCheckBox();
+        cbLockTheirScrolling.setName("checkbox.locktheirscrolling");
+        add(buildAdjustmentLockControlPanel(cbLockTheirScrolling), gc);
+
+        // --------------------------------
+        gc.gridx = 0;
+        gc.gridy = 2;
         gc.gridwidth = 1;
         gc.gridheight = 1;
         gc.fill = GridBagConstraints.BOTH;
         gc.anchor = GridBagConstraints.FIRST_LINE_START;
-        gc.weightx = 0.3;
+        gc.weightx = 0.33;
         gc.weighty = 1.0;
         gc.insets = new Insets(0,0,0,0);
-        add(buildMyElementsTable(), gc);
+        JScrollPane pane = buildMyElementsTable();
+        adjustmentSynchronizer.adapt(cbLockMyScrolling, pane.getVerticalScrollBar());
+        add(pane, gc);
 
         gc.gridx = 1;
-        gc.gridy = 1;
-        gc.gridwidth = 1;
-        gc.gridheight = 1;
+        gc.gridy = 2;
         gc.fill = GridBagConstraints.NONE;
         gc.anchor = GridBagConstraints.CENTER;
@@ -270 +305 @@
 
         gc.gridx = 2;
-        gc.gridy = 1;
-        gc.gridwidth = 1;
-        gc.gridheight = 1;
+        gc.gridy = 2;
         gc.fill = GridBagConstraints.BOTH;
         gc.anchor = GridBagConstraints.FIRST_LINE_START;
-        gc.weightx = 0.3;
+        gc.weightx = 0.33;
         gc.weighty = 0.0;
-        add(buildMergedElementsTable(), gc);
+        pane = buildMergedElementsTable();
+        adjustmentSynchronizer.adapt(cbLockMergedScrolling, pane.getVerticalScrollBar());
+        add(pane, gc);
 
         gc.gridx = 3;
-        gc.gridy = 1;
-        gc.gridwidth = 1;
-        gc.gridheight = 1;
+        gc.gridy = 2;
         gc.fill = GridBagConstraints.NONE;
         gc.anchor = GridBagConstraints.CENTER;
@@ -290 +323 @@
 
         gc.gridx = 4;
-        gc.gridy = 1;
-        gc.gridwidth = 1;
-        gc.gridheight = 1;
+        gc.gridy = 2;
         gc.fill = GridBagConstraints.BOTH;
         gc.anchor = GridBagConstraints.FIRST_LINE_START;
-        gc.weightx = 0.3;
+        gc.weightx = 0.33;
         gc.weighty = 0.0;
-        add(buildTheirElementsTable(), gc);
-
+        pane = buildTheirElementsTable();
+        adjustmentSynchronizer.adapt(cbLockTheirScrolling, pane.getVerticalScrollBar());
+        add(pane, gc);
+
+        // ----------------------------------
         gc.gridx = 2;
-        gc.gridy = 2;
+        gc.gridy = 3;
         gc.gridwidth = 1;
         gc.gridheight = 1;
         gc.fill = GridBagConstraints.BOTH;
         gc.anchor = GridBagConstraints.CENTER;
-        gc.weightx = 0.3;
+        gc.weightx = 0.0;
         gc.weighty = 0.0;
         add(buildMergedListControlButtons(), gc);
@@ -317 +351 @@
         model.addPropertyChangeListener(this);
     }
-
 
     /**
@@ -666 +699 @@
          */
         public void adapt(final JToggleButton btn) {
-            //            btn.addItemListener(
-            //                    new ItemListener() {
-            //                        public void itemStateChanged(ItemEvent e) {
-            //                            boolean isSelected = (Boolean)getValue(PROP_SELECTED);
-            //                            if (isSelected != (e.getStateChange() == ItemEvent.SELECTED)) {
-            //                                putValue(PROP_SELECTED, e.getStateChange() == ItemEvent.SELECTED);
-            //                            }
-            //                            model.setFrozen(e.getStateChange() == ItemEvent.SELECTED);
-            //                        }
-            //                    }
-            //            );
             btn.addItemListener(this);
             addPropertyChangeListener(
@@ -728 +750 @@
         return model;
     }
+
+
+
+    /**
+     * Synchronizes scrollbar adjustments between a set of
+     * {@see Adjustable}s. Whenever the adjustment of one of
+     * the registerd Adjustables is updated the adjustment of
+     * the other registered Adjustables is adjusted too.
+     * 
+     */
+    class AdjustmentSynchronizer implements AdjustmentListener {
+
+        private final  ArrayList<Adjustable> synchronizedAdjustables;
+        private final  HashMap<Adjustable, Boolean> enabledMap;
+
+        private final Observable observable;
+
+        public AdjustmentSynchronizer() {
+            synchronizedAdjustables = new ArrayList<Adjustable>();
+            enabledMap = new HashMap<Adjustable, Boolean>();
+            observable = new Observable();
+        }
+
+
+        /**
+         * registers an {@see Adjustable} for participation in synchronized
+         * scrolling.
+         * 
+         * @param adjustable the adjustable
+         */
+        public void participateInSynchronizedScrolling(Adjustable adjustable) {
+            if (adjustable == null)
+                return;
+            if (synchronizedAdjustables.contains(adjustable))
+                return;
+            synchronizedAdjustables.add(adjustable);
+            setParticipatingInSynchronizedScrolling(adjustable, true);
+            adjustable.addAdjustmentListener(this);
+        }
+
+        /**
+         * event handler for {@see AdjustmentEvent}s
+         * 
+         */
+        public void adjustmentValueChanged(AdjustmentEvent e) {
+            if (! enabledMap.get(e.getAdjustable()))
+                return;
+            for (Adjustable a : synchronizedAdjustables) {
+                if (a != e.getAdjustable() && isParticipatingInSynchronizedScrolling(a)) {
+                    a.setValue(e.getValue());
+                }
+            }
+        }
+
+        /**
+         * sets whether adjustable participates in adjustment synchronization
+         * or not
+         * 
+         * @param adjustable the adjustable
+         */
+        protected void setParticipatingInSynchronizedScrolling(Adjustable adjustable, boolean isParticipating) {
+            if (adjustable == null)
+                throw new IllegalArgumentException(tr("argument \"adjustable\" must not be null"));
+
+            if (! synchronizedAdjustables.contains(adjustable))
+                throw new IllegalStateException(tr("adjustable {0} not registered yet. Can't set participation in synchronized adjustment",adjustable));
+
+            enabledMap.put(adjustable, isParticipating);
+            observable.notifyObservers();
+        }
+
+        /**
+         * returns true if an adjustable is participating in synchronized scrolling
+         * 
+         * @param adjustable the adjustable
+         * @return true, if the adjustable is participating in synchronized scrolling, false otherwise
+         * @throws IllegalStateException thrown, if adjustable is not registered for synchronized scrolling
+         */
+        protected boolean isParticipatingInSynchronizedScrolling(Adjustable adjustable) throws IllegalStateException {
+            if (! synchronizedAdjustables.contains(adjustable))
+                throw new IllegalStateException(tr("adjustable {0} not registered yet",adjustable));
+
+            return enabledMap.get(adjustable);
+        }
+
+        /**
+         * wires a {@see JCheckBox} to  the adjustment synchronizer, in such a way  that:
+         * <li>
+         *   <ol>state changes in the checkbox control whether the adjustable participates
+         *      in synchronized adjustment</ol>
+         *   <ol>state changes in this {@see AdjustmentSynchronizer} are reflected in the
+         *      {@see JCheckBox}</ol>
+         * </li>
+         * 
+         * 
+         * @param view  the checkbox to control whether an adjustable participates in synchronized
+         *      adjustment
+         * @param adjustable the adjustable
+         * @exception IllegalArgumentException thrown, if view is null
+         * @exception IllegalArgumentException thrown, if adjustable is null
+         */
+        protected void adapt(final JCheckBox view, final Adjustable adjustable) throws IllegalArgumentException, IllegalStateException {
+            if (adjustable == null)
+                throw new IllegalArgumentException(tr("argument \"adjustable\" must not be null"));
+            if (view == null)
+                throw new IllegalArgumentException(tr("argument \"view\" must not be null"));
+
+            if (! synchronizedAdjustables.contains(adjustable)) {
+                participateInSynchronizedScrolling(adjustable);
+            }
+
+            // register an item lister with the check box
+            //
+            view.addItemListener(new ItemListener() {
+                public void itemStateChanged(ItemEvent e) {
+                    switch(e.getStateChange()) {
+                    case ItemEvent.SELECTED:
+                        if (!isParticipatingInSynchronizedScrolling(adjustable)) {
+                            setParticipatingInSynchronizedScrolling(adjustable, true);
+                        }
+                        break;
+                    case ItemEvent.DESELECTED:
+                        if (isParticipatingInSynchronizedScrolling(adjustable)) {
+                            setParticipatingInSynchronizedScrolling(adjustable, false);
+                        }
+                        break;
+                    }
+                }
+            });
+
+
+            observable.addObserver(
+                    new Observer() {
+                        public void update(Observable o, Object arg) {
+                            boolean sync = isParticipatingInSynchronizedScrolling(adjustable);
+                            if (view.isSelected() != sync) {
+                                view.setSelected(sync);
+                            }
+                        }
+                    }
+            );
+            setParticipatingInSynchronizedScrolling(adjustable, true);
+            view.setSelected(true);
+        }
+    }
 }

trunk/src/org/openstreetmap/josm/gui/conflict/nodes/NodeListColumnModel.java

@@ -14 +14 @@
         TableColumn col = null;
 
-        // column 0 - Node
+        // column 0 - Row num
         col = new TableColumn(0);
+        col.setHeaderValue("");
+        col.setResizable(false);
+        col.setWidth(30);
+        col.setMaxWidth(30);
+        col.setCellRenderer(renderer);
+        addColumn(col);
+
+        // column 1 - Node
+        col = new TableColumn(1);
         col.setHeaderValue(tr("Node"));
         col.setResizable(true);

trunk/src/org/openstreetmap/josm/gui/conflict/nodes/NodeListMerger.java

@@ -32 +32 @@
         );
         myEntriesTable.setName("table.mynodes");
+        myEntriesTable.setAutoResizeMode(JTable.AUTO_RESIZE_LAST_COLUMN);
         return embeddInScrollPane(myEntriesTable);
     }
@@ -45 +46 @@
         );
         mergedEntriesTable.setName("table.mergednodes");
+        mergedEntriesTable.setAutoResizeMode(JTable.AUTO_RESIZE_LAST_COLUMN);
         return embeddInScrollPane(mergedEntriesTable);
     }
@@ -58 +60 @@
         );
         theirEntriesTable.setName("table.theirnodes");
+        theirEntriesTable.setAutoResizeMode(JTable.AUTO_RESIZE_LAST_COLUMN);
         return embeddInScrollPane(theirEntriesTable);
     }

trunk/src/org/openstreetmap/josm/gui/conflict/nodes/NodeListTableCellRenderer.java

@@ -6 +6 @@
 import java.awt.Color;
 import java.awt.Component;
-import java.net.URL;
 import java.text.DecimalFormat;
 
+import javax.swing.BorderFactory;
 import javax.swing.ImageIcon;
 import javax.swing.JLabel;
 import javax.swing.JTable;
+import javax.swing.border.Border;
 import javax.swing.table.TableCellRenderer;
 
 import org.openstreetmap.josm.data.osm.Node;
+import org.openstreetmap.josm.tools.ImageProvider;
 
 /**
  * This is the {@see TableCellRenderer} used in the node tables of {@see NodeListMerger}.
  * 
- *
  */
 public  class NodeListTableCellRenderer extends JLabel implements TableCellRenderer {
     private static DecimalFormat COORD_FORMATTER = new DecimalFormat("###0.0000");
     public final static Color BGCOLOR_SELECTED = new Color(143,170,255);
+    public final static Color BGCOLOR_EMPTY_ROW = new Color(234,234,234);
 
-    /**
-     * Load the image icon for an OSM primitive of type node
-     * 
-     * @return the icon; null, if not found
-     */
-    protected ImageIcon loadIcon() {
-        URL url = this.getClass().getResource("/images/data/node.png");;
-        if (url == null) {
-            System.out.println(tr("Failed to load resource /images/data/node.png"));
-            return null;
-        }
-        return new ImageIcon(url);
-    }
+    private ImageIcon icon = null;
+    private Border rowNumberBorder = null;
 
     /**
@@ -43 +34 @@
      */
     public NodeListTableCellRenderer() {
-        setIcon(loadIcon());
+        icon = ImageProvider.get("data", "node");
+        rowNumberBorder = BorderFactory.createEmptyBorder(0,4,0,0);
         setOpaque(true);
     }
@@ -90 +82 @@
      */
     protected  void renderNode(Node node, boolean isSelected) {
+        setIcon(icon);
+        setBorder(null);
         if (isSelected) {
             setBackground(BGCOLOR_SELECTED);
         }
         setText(getDisplayName(node));
+    }
+
+    protected void renderEmptyRow() {
+        setIcon(null);
+        setBackground(BGCOLOR_EMPTY_ROW);
+        setText("");
+    }
+
+    /**
+     * render the row id
+     * @param row the row index
+     * @param isSelected
+     */
+    protected  void renderRowId(int row, boolean isSelected) {
+        setIcon(null);
+        setBorder(rowNumberBorder);
+        if (isSelected) {
+            setBackground(BGCOLOR_SELECTED);
+        }
+        setText(Integer.toString(row+1));
     }
 
@@ -101 +115 @@
         Node node = (Node)value;
         reset();
-        renderNode(node,isSelected);
+        switch(column) {
+        case 0:
+            renderRowId(row, isSelected);
+            break;
+        case 1:
+            if (node == null) {
+                renderEmptyRow();
+            } else {
+                renderNode(node,isSelected);
+            }
+            break;
+        default:
+            // should not happen
+            throw new RuntimeException(tr("unexpected column index. Got {0}", column));
+        }
         return this;
     }

trunk/src/org/openstreetmap/josm/gui/conflict/relation/RelationMemberListColumnModel.java

@@ -15 +15 @@
         // column 0 - Role
         col = new TableColumn(0);
+        col.setHeaderValue("");
+        col.setResizable(false);
+        col.setWidth(20);
+        col.setMaxWidth(20);
+        col.setCellRenderer(renderer);
+        addColumn(col);
+
+        // column 1 - Role
+        col = new TableColumn(1);
         col.setHeaderValue(tr("Role"));
         col.setResizable(true);
         col.setCellRenderer(renderer);
+        col.setMaxWidth(100);
         col.setCellEditor(new RelationMemberTableCellEditor());
         addColumn(col);
 
-        // column 1 - Primitive
-        col = new TableColumn(1);
+        // column 2 - Primitive
+        col = new TableColumn(2);
         col.setHeaderValue(tr("Primitive"));
         col.setResizable(true);

trunk/src/org/openstreetmap/josm/gui/conflict/relation/RelationMemberListMergeModel.java

@@ -37 +37 @@
         // editing cells in the first column
         //
-        mergedEntriesTableModel = this.new ListTableModel<RelationMember>(mergedEntries) {
+        mergedEntriesTableModel = this.new EntriesTableModel<RelationMember>(mergedEntries) {
             @Override
             public boolean isCellEditable(int row, int column) {
                 switch(column) {
-                case 0: return true;
+                case 1: return true;
                 default: return false;
                 }
@@ -50 +50 @@
     @Override
     protected void setValueAt(DefaultTableModel model, Object value, int row, int col) {
-        if (model == getMergedTableModel() && col == 0) {
+        if (model == getMergedTableModel() && col == 1) {
             RelationMember member = mergedEntries.get(row);
             member.role = (String)value;

trunk/src/org/openstreetmap/josm/gui/conflict/relation/RelationMemberMerger.java

@@ -25 +25 @@
         );
         myEntriesTable.setName("table.mynodes");
+        myEntriesTable.setAutoResizeMode(JTable.AUTO_RESIZE_LAST_COLUMN);
         return embeddInScrollPane(myEntriesTable);
     }
@@ -30 +31 @@
     @Override
     protected JScrollPane buildMergedElementsTable() {
-        logger.info(model.getMergedTableModel().toString());
         mergedEntriesTable  = new JTable(
                 model.getMergedTableModel(),
@@ -38 +38 @@
         mergedEntriesTable.putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
         mergedEntriesTable.setName("table.mergednodes");
+        mergedEntriesTable.setAutoResizeMode(JTable.AUTO_RESIZE_LAST_COLUMN);
         return embeddInScrollPane(mergedEntriesTable);
     }
@@ -49 +50 @@
         );
         theirEntriesTable.setName("table.theirnodes");
+        theirEntriesTable.setAutoResizeMode(JTable.AUTO_RESIZE_LAST_COLUMN);
         return embeddInScrollPane(theirEntriesTable);
     }

trunk/src/org/openstreetmap/josm/gui/conflict/relation/RelationMemberTableCellRenderer.java

@@ -8 +8 @@
 import java.text.DecimalFormat;
 
+import javax.swing.BorderFactory;
 import javax.swing.ImageIcon;
 import javax.swing.JLabel;
 import javax.swing.JTable;
+import javax.swing.border.Border;
 import javax.swing.table.TableCellRenderer;
 
@@ -23 +25 @@
  * This is the {@see TableCellRenderer} used in the tables of {@see RelationMemberMerger}.
  * 
- *
  */
 public  class RelationMemberTableCellRenderer extends JLabel implements TableCellRenderer {
-    private static DecimalFormat COORD_FORMATTER = new DecimalFormat("###0.0000");
+    private final static DecimalFormat COORD_FORMATTER = new DecimalFormat("###0.0000");
     public final static Color BGCOLOR_SELECTED = new Color(143,170,255);
+    public final static Color BGCOLOR_EMPTY_ROW = new Color(234,234,234);
 
     private ImageIcon nodeIcon;
     private ImageIcon wayIcon;
     private ImageIcon relationIcon;
+    private  Border rowNumberBorder = null;
 
     /**
@@ -51 +54 @@
         setOpaque(true);
         loadIcons();
+        rowNumberBorder = BorderFactory.createEmptyBorder(0,4,0,0);
     }
 
@@ -100 +104 @@
         setBackground(Color.WHITE);
         setForeground(Color.BLACK);
+        setBorder(null);
+        setIcon(null);
+        setToolTipText(null);
     }
 
@@ -110 +117 @@
     protected void renderRole(RelationMember member) {
         setText(member.role == null ? "" : member.role);
-        setIcon(null);
+        setToolTipText(member.role == null ? "" : member.role);
     }
 
@@ -129 +136 @@
     }
 
+    /**
+     * render the row id
+     * @param row the row index
+     * @param isSelected
+     */
+    protected  void renderRowId(int row, boolean isSelected) {
+        setBorder(rowNumberBorder);
+        setText(Integer.toString(row+1));
+    }
+
+    protected void renderEmptyRow() {
+        setIcon(null);
+        setBackground(BGCOLOR_EMPTY_ROW);
+        setText("");
+    }
+
+
     public Component getTableCellRendererComponent(JTable table, Object value, boolean isSelected, boolean hasFocus,
             int row, int column) {
@@ -137 +161 @@
         switch(column) {
         case 0:
-            renderRole(member);
+            renderRowId(row, isSelected);
             break;
         case 1:
-            renderPrimitive(member);
+            if (member == null) {
+                renderEmptyRow();
+            } else {
+                renderRole(member);
+            }
+            break;
+        case 2:
+            if (member == null) {
+                renderEmptyRow();
+            } else {
+                renderPrimitive(member);
+            }
             break;
         default:

trunk/src/org/openstreetmap/josm/gui/conflict/tags/MergedTableCellRenderer.java

@@ -6 +6 @@
 import java.awt.Color;
 
-public class UndecidedTableCellRenderer extends TagMergeTableCellRenderer {
+public class MergedTableCellRenderer extends TagMergeTableCellRenderer {
 
     public final static Color BGCOLOR_UNDECIDED = new Color(255,197,197);

trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagMerger.java

@@ -13 +13 @@
 import java.awt.event.MouseAdapter;
 import java.awt.event.MouseEvent;
-import java.net.URL;
 import java.util.ArrayList;
 
@@ -27 +26 @@
 import javax.swing.event.ListSelectionListener;
 
+import org.openstreetmap.josm.tools.ImageProvider;
+/**
+ * UI component for resolving conflicts in the tag sets of two {@see OsmPrimitive}s.
+ *
+ */
 public class TagMerger extends JPanel {
 
@@ -37 +41 @@
     AdjustmentSynchronizer adjustmentSynchronizer;
 
+    /**
+     * embeds table in a new {@see JScrollPane} and returns th scroll pane
+     * 
+     * @param table the table
+     * @return the scroll pane embedding the table
+     */
     protected JScrollPane embeddInScrollPane(JTable table) {
         JScrollPane pane = new JScrollPane(table);
@@ -46 +56 @@
     }
 
+    /**
+     * builds the table for my tag set (table already embedded in a scroll pane)
+     * 
+     * @return the table (embedded in a scroll pane)
+     */
     protected JScrollPane buildMineTagTable() {
         mineTable  = new JTable(
@@ -57 +72 @@
     }
 
+    /**
+     * builds the table for their tag set (table already embedded in a scroll pane)
+     * 
+     * @return the table (embedded in a scroll pane)
+     */
     protected JScrollPane buildTheirTable() {
         theirTable  = new JTable(
@@ -68 +88 @@
     }
 
-    protected JScrollPane buildUndecidedTable() {
+    /**
+     * builds the table for the merged tag set (table already embedded in a scroll pane)
+     * 
+     * @return the table (embedded in a scroll pane)
+     */
+
+    protected JScrollPane buildMergedTable() {
         mergedTable  = new JTable(
                 model,
                 new TagMergeColumnModel(
-                        new UndecidedTableCellRenderer()
+                        new MergedTableCellRenderer()
                 )
         );
@@ -79 +105 @@
     }
 
+    /**
+     * build the user interface
+     */
     protected void build() {
         GridBagConstraints gc = new GridBagConstraints();
@@ -152 +181 @@
         gc.weightx = 0.3;
         gc.weighty = 1.0;
-        add(buildUndecidedTable(), gc);
+        add(buildMergedTable(), gc);
 
         gc.gridx = 3;
@@ -205 +234 @@
     }
 
+    /**
+     * replies the model used by this tag merger
+     * 
+     * @return the model
+     */
     public TagMergeModel getModel() {
         return model;
     }
 
-    protected ImageIcon loadIcon(String name) {
-        String path = "/images/dialogs/conflict/" + name;
-        URL url = this.getClass().getResource(path);
-        if (url == null) {
-            System.out.println(tr("WARNING: failed to load resource {0}", path));
-            return null;
-        }
-        return new ImageIcon(url);
-    }
-
+    /**
+     * Keeps the currently selected tags in my table in the list of merged tags.
+     *
+     */
     class KeepMineAction extends AbstractAction implements ListSelectionListener {
-
-
         public KeepMineAction() {
-            ImageIcon icon = loadIcon("tagkeepmine.png");
+            ImageIcon icon = ImageProvider.get("dialogs/conflict", "tagkeepmine.png");
             if (icon != null) {
                 putValue(Action.SMALL_ICON, icon);
@@ -246 +272 @@
     }
 
+    /**
+     * Keeps the currently selected tags in their table in the list of merged tags.
+     *
+     */
     class KeepTheirAction extends AbstractAction implements ListSelectionListener {
-
         public KeepTheirAction() {
-            ImageIcon icon = loadIcon("tagkeeptheir.png");
+            ImageIcon icon = ImageProvider.get("dialogs/conflict", "tagkeeptheir.png");
             if (icon != null) {
                 putValue(Action.SMALL_ICON, icon);
@@ -272 +301 @@
     }
 
+    /**
+     * Synchronizes scrollbar adjustments between a set of
+     * {@see Adjustable}s. Whenever the adjustment of one of
+     * the registerd Adjustables is updated the adjustment of
+     * the other registered Adjustables is adjusted too.
+     * 
+     */
     class AdjustmentSynchronizer implements AdjustmentListener {
         private final ArrayList<Adjustable> synchronizedAdjustables;
@@ -297 +333 @@
     }
 
+    /**
+     * Handler for double clicks on entries in the three tag tables.
+     * 
+     */
     class DoubleClickAdapter extends MouseAdapter {
 
@@ -324 +364 @@
     }
 
+    /**
+     * Sets the currently selected tags in the table of merged tags to state
+     * {@see MergeDecisionType#UNDECIDED}
+     * 
+     */
     class UndecideAction extends AbstractAction implements ListSelectionListener  {
 
         public UndecideAction() {
-            ImageIcon icon = loadIcon("tagundecide.png");
+            ImageIcon icon = ImageProvider.get("dialogs/conflict", "tagundecide.png");
             if (icon != null) {
                 putValue(Action.SMALL_ICON, icon);

trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictDialog.java

@@ -51 +51 @@
     private final DefaultListModel model = new DefaultListModel();
     private final JList displaylist = new JList(model);
-    
+
     private final SideButton sbSelect = new SideButton(marktr("Select"), "select", "Conflict",
             tr("Set the selected elements on the map to the selected items in the list above."), new ActionListener(){
-                public void actionPerformed(ActionEvent e) {
-                    Collection<OsmPrimitive> sel = new LinkedList<OsmPrimitive>();
-                    for (Object o : displaylist.getSelectedValues())
-                        sel.add((OsmPrimitive)o);
-                    Main.ds.setSelected(sel);
-                }
-            });
+        public void actionPerformed(ActionEvent e) {
+            Collection<OsmPrimitive> sel = new LinkedList<OsmPrimitive>();
+            for (Object o : displaylist.getSelectedValues()) {
+                sel.add((OsmPrimitive)o);
+            }
+            Main.ds.setSelected(sel);
+        }
+    });
     private final SideButton sbResolve = new SideButton(marktr("Resolve"), "conflict", "Conflict",
             tr("Open a merge dialog of all selected items in the list above."), new ActionListener(){
@@ -70 +71 @@
     public ConflictDialog() {
         super(tr("Conflict"), "conflict", tr("Merging conflicts."),
-        Shortcut.registerShortcut("subwindow:conflict", tr("Toggle: {0}", tr("Conflict")), KeyEvent.VK_C, Shortcut.GROUP_LAYER), 100);
+                Shortcut.registerShortcut("subwindow:conflict", tr("Toggle: {0}", tr("Conflict")), KeyEvent.VK_C, Shortcut.GROUP_LAYER), 100);
         displaylist.setCellRenderer(new OsmPrimitivRenderer());
         displaylist.setSelectionMode(ListSelectionModel.MULTIPLE_INTERVAL_SELECTION);
         displaylist.addMouseListener(new MouseAdapter(){
             @Override public void mouseClicked(MouseEvent e) {
-                if (e.getClickCount() >= 2)
+                if (e.getClickCount() >= 2) {
                     resolve();
+                }
             }
         });
@@ -102 +104 @@
             }
         });
-        
+
         rebuildList();
     }
@@ -110 +112 @@
         method = method.trim().toLowerCase();
         if (method.equals("traditional")) {
-            resolveTraditional();            
+            resolveTraditional();
         } else if (method.equals("extended")) {
             resolveExtended();
@@ -118 +120 @@
         }
     }
-    
-    
+
+
     private final void resolveExtended() {
-        if(model.size() == 1)
+        if(model.size() == 1) {
             displaylist.setSelectedIndex(0);
-        
+        }
+
         if (displaylist.getSelectedIndex() == -1)
             return;
-        
+
         int [] selectedRows = displaylist.getSelectedIndices();
-        if (selectedRows == null || selectedRows.length == 0) {
-            return; 
-        }
+        if (selectedRows == null || selectedRows.length == 0)
+            return;
         int row = selectedRows[0];
         OsmPrimitive my = (OsmPrimitive)model.get(row);
         OsmPrimitive their = conflicts.get(my);
-        ConflictResolutionDialog dialog = new ConflictResolutionDialog(Main.parent);      
+        ConflictResolutionDialog dialog = new ConflictResolutionDialog(Main.parent);
         dialog.getConflictResolver().populate(my, their);
         dialog.setVisible(true);
         Main.map.mapView.repaint();
     }
-    
-    
+
+
     private final void resolveTraditional() {
-        if(model.size() == 1)
+        if(model.size() == 1) {
             displaylist.setSelectedIndex(0);
-        
+        }
+
         if (displaylist.getSelectedIndex() == -1)
             return;
@@ -154 +157 @@
         ConflictResolver resolver = new ConflictResolver(sel);
         int answer = new ExtendedDialog(Main.parent,
-                          tr("Resolve Conflicts"),
-                          resolver,
-                          new String[] { tr("Solve Conflict"), tr("Cancel") },
-                          new String[] { "dialogs/conflict.png", "cancel.png"} 
-        ).getValue(); 
+                tr("Resolve Conflicts"),
+                resolver,
+                new String[] { tr("Solve Conflict"), tr("Cancel") },
+                new String[] { "dialogs/conflict.png", "cancel.png"}
+        ).getValue();
 
         if (answer != 1)
@@ -171 +174 @@
             model.addElement(osm);
         }
-        
+
         if(model.size() != 0) {
             setTitle(tr("Conflicts: {0}", model.size()), true);
@@ -177 +180 @@
             setTitle(tr("Conflicts"), false);
         }
-        
+
         sbSelect.setEnabled(model.size() > 0);
         sbResolve.setEnabled(model.size() > 0);
@@ -185 +188 @@
         this.conflicts.putAll(conflicts);
         rebuildList();
+    }
+
+
+    /**
+     * removes a conflict registered for {@see OsmPrimitive} <code>my</code>
+     * 
+     * @param my the {@see OsmPrimitive} for which a conflict is registered
+     *   with this dialog
+     */
+    public void removeConflictForPrimitive(OsmPrimitive my) {
+        if (! conflicts.keySet().contains(my))
+            return;
+        conflicts.remove(my);
+        rebuildList();
+        repaint();
+    }
+
+    /**
+     * registers a conflict with this dialog. The conflict is represented
+     * by a pair of {@see OsmPrimitive} with differences in their tag sets,
+     * their node lists (for {@see Way}s) or their member lists (for {@see Relation}s)
+     * 
+     * @param my  my version of the {@see OsmPrimitive}
+     * @param their their version of the {@see OsmPrimitive}
+     */
+    public void addConflict(OsmPrimitive my, OsmPrimitive their) {
+        conflicts.put(my, their);
+        rebuildList();
+        repaint();
     }
 
@@ -222 +254 @@
             }
             public void visit(Relation e) {
-                for (RelationMember em : e.members)
+                for (RelationMember em : e.members) {
                     em.member.visit(this);
+                }
             }
         };

trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictResolutionDialog.java

@@ -169 +169 @@
 
         public void actionPerformed(ActionEvent arg0) {
+            if (! resolver.isCompletelyResolved()) {
+                Object[] options = {
+                        tr("Apply partial resolutions"),
+                        tr("Continue resolving")};
+                int n = JOptionPane.showOptionDialog(null,
+                        tr("<html>You didn''t finish to resolve all conflicts.<br>"
+                                + "Click <strong>{0}</strong> to apply already resolved conflicts anyway.<br>"
+                                + "You can resolve the remaining conflicts later.<br>"
+                                + "Click <strong>{1}</strong> to return to resolving conflicts.</html>"
+                                , options[0].toString(), options[1].toString()
+                        ),
+                        tr("Warning"),
+                        JOptionPane.YES_NO_OPTION,
+                        JOptionPane.WARNING_MESSAGE,
+                        null,
+                        options,
+                        options[1]
+                );
+                if (n == JOptionPane.NO_OPTION || n == JOptionPane.CLOSED_OPTION)
+                    return;
+            }
             Command cmd = resolver.buildResolveCommand();
             Main.main.undoRedo.add(cmd);