Changeset 16385 in josm for trunk

Timestamp:

2020-04-28T22:24:09+02:00 (4 years ago)

Author:

simon04

Message:

see #19074 - TagInfoExtract: count optional preset tag usages

File:

• trunk/scripts/TagInfoExtract.java (modified) (3 diffs)

trunk/scripts/TagInfoExtract.java

@@ -283 +283 @@
                                     optionalTags.compute(new Tag(item.key, value), (osmTag, tagInfoTag) -> {
                                         if (tagInfoTag == null) {
-                                            String description = descriptionPrefix + "Optional for: " + preset.getName();
+                                            String description = descriptionPrefix + TagInfoTag.OPTIONAL_FOR_COUNT + ": " + preset.getName();
                                             return new TagInfoTag(description, item.key, value, types, null);
                                         } else {
@@ -551 +551 @@
      */
     private static class TagInfoTag {
+        static final String OPTIONAL_FOR_COUNT = "Optional for {count}";
         final Collection<String> descriptions = new ArrayList<>();
         final String key;
@@ -570 +571 @@
             final JsonObjectBuilder object = Json.createObjectBuilder();
             if (!descriptions.isEmpty()) {
-                object.add("description", String.join(", ", Utils.limit(descriptions, 8, "...")));
+                final int size = descriptions.size();
+                object.add("description", String.join(", ", Utils.limit(descriptions, 8, "..."))
+                        .replace(OPTIONAL_FOR_COUNT, size > 3 ? "Optional for " + size : "Optional for"));
             }
             object.add("key", key);