Changeset 16296 in josm for trunk/test

Timestamp:

2020-04-14T07:14:38+02:00 (4 years ago)

Author:

GerdP

Message:

fix #19053:Validator does not find overlapping buildings anymore

• improve handling of ignore action for messages produced by MapCSSTagCheckerTest. This requires a change in the entries stored in preferences.xml.
• partly revert r16247 to re-enable ignore button for groups
• add code to recognize and remove ignore list entries produced with older version of JOSM. Users have to re-add those items by ignoring the errors again.

File:

• trunk/test/unit/org/openstreetmap/josm/data/validation/tests/MapCSSTagCheckerTest.java (modified) (3 diffs)

trunk/test/unit/org/openstreetmap/josm/data/validation/tests/MapCSSTagCheckerTest.java

@@ -145 +145 @@
         assertEquals(1, errors.size());
         assertEquals("has alt_name but not name", errors.iterator().next().getMessage());
-        assertEquals("3000_*[.+_name][!name]", errors.iterator().next().getIgnoreSubGroup());
+        assertEquals("3000_has alt_name but not name", errors.iterator().next().getIgnoreSubGroup());
     }
 
@@ -160 +160 @@
         assertEquals(1, errors.size());
         assertEquals("footway used with foot=no", errors.iterator().next().getMessage());
-        assertEquals("3000_way[highway=footway][foot]", errors.iterator().next().getIgnoreSubGroup());
+        assertEquals("3000_footway used with foot=no", errors.iterator().next().getIgnoreSubGroup());
     }
 
@@ -414 +414 @@
     }
 
+    /**
+     * Non-regression test for <a href="https://josm.openstreetmap.de/ticket/19053">Bug #19053</a>.
+     * Mapcss rule with group.
+     * @throws ParseException if a parsing error occurs
+     */
+    @Test
+    public void testTicket19053() throws ParseException {
+        final MapCSSTagChecker test = buildTagChecker(
+                "*[ele][ele =~ /^-?[0-9]+\\.[0-9][0-9][0-9]+$/] {"
+                        + "throwWarning: tr(\"{0}\",\"{0.tag}\");"
+                        + "group: tr(\"Unnecessary amount of decimal places\");" + "}");
+        final OsmPrimitive p = OsmUtils.createPrimitive("node ele=12.123456");
+        final Collection<TestError> errors = test.getErrorsForPrimitive(p, false);
+        assertEquals(1, errors.size());
+        assertEquals("Unnecessary amount of decimal places", errors.iterator().next().getMessage());
+        assertEquals("3000_ele=12.123456", errors.iterator().next().getIgnoreSubGroup());
+        assertEquals("3000_Unnecessary amount of decimal places", errors.iterator().next().getIgnoreGroup());
+    }
+
 }