Changeset 16153 in josm

Timestamp:

2020-03-16T21:23:20+01:00 (4 years ago)

Author:

simon04

Message:

fix #18941 - MapImage.getImageResource: wait for image to load

File:

• trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/MapImage.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/MapImage.java

@@ -10 +10 @@
 import java.awt.image.BufferedImage;
 import java.util.Objects;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
 
 import javax.swing.ImageIcon;
@@ -22 +24 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.ImageResource;
+import org.openstreetmap.josm.tools.Logging;
 import org.openstreetmap.josm.tools.Utils;
 
@@ -115 +118 @@
     /**
      * Get the image resource associated with this MapImage object.
+     * This method blocks until the image has been loaded.
      * @return the image resource
      */
     public ImageResource getImageResource() {
+        if (imageResource == null) {
+            try {
+                // load and wait for the image
+                loadImage().get();
+            } catch (ExecutionException | InterruptedException e) {
+                Logging.warn(e);
+                Thread.currentThread().interrupt();
+            }
+        }
         return imageResource;
     }
@@ -142 +155 @@
             return img;
         temporary = false;
-        new ImageProvider(name)
+        loadImage();
+        synchronized (this) {
+            if (img == null) {
+                img = ImageProvider.get("clock").getImage();
+                temporary = true;
+            }
+        }
+        return img;
+    }
+
+    private CompletableFuture<Void> loadImage() {
+        return new ImageProvider(name)
                 .setDirs(MapPaintStyles.getIconSourceDirs(source))
                 .setId("mappaint."+source.getPrefName())
@@ -168 +192 @@
                 }
         );
-        synchronized (this) {
-            if (img == null) {
-                img = ImageProvider.get("clock").getImage();
-                temporary = true;
-            }
-        }
-        return img;
     }