Changeset 16122 in josm for trunk/src/org/openstreetmap

Timestamp:

2020-03-14T15:49:56+01:00 (4 years ago)

Author:

Don-vip

Message:

ChangesetContentPanel: code cleanup

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetContentPanel.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetContentPanel.java

@@ -14 +14 @@
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashSet;
+import java.util.Collections;
 import java.util.List;
+import java.util.Objects;
 import java.util.Set;
 import java.util.stream.Collectors;
@@ -30 +31 @@
 import javax.swing.JTable;
 import javax.swing.JToolBar;
+import javax.swing.SwingConstants;
 import javax.swing.event.ListSelectionEvent;
 import javax.swing.event.ListSelectionListener;
@@ -63 +65 @@
  * It listens to property change events for {@link ChangesetCacheManagerModel#CHANGESET_IN_DETAIL_VIEW_PROP}
  * and updates its view accordingly.
- *
+ * @since 2689
  */
 public class ChangesetContentPanel extends JPanel implements PropertyChangeListener, ChangesetAware {
@@ -76 +78 @@
 
     private final HeaderPanel pnlHeader = new HeaderPanel();
-    public DownloadObjectAction actDownloadObjectAction;
+    protected DownloadObjectAction actDownloadObjectAction;
 
     protected void buildModels() {
@@ -131 +133 @@
     protected JPanel buildActionButtonPanel() {
         JPanel pnl = new JPanel(new FlowLayout(FlowLayout.LEFT));
-        JToolBar tb = new JToolBar(JToolBar.VERTICAL);
+        JToolBar tb = new JToolBar(SwingConstants.VERTICAL);
         tb.setFloatable(false);
 
@@ -321 +323 @@
 
         protected Set<OsmPrimitive> getTarget() {
-            if (!isEnabled()) {
-                return null;
-            }
             DataSet ds = MainApplication.getLayerManager().getActiveDataSet();
-            if (ds == null) {
-                return null;
-            }
-            Set<OsmPrimitive> target = new HashSet<>();
-            for (HistoryOsmPrimitive p : model.getSelectedPrimitives()) {
-                OsmPrimitive op = ds.getPrimitiveById(p.getPrimitiveId());
-                if (op != null) {
-                    target.add(op);
-                }
-            }
-            return target;
+            if (isEnabled() && ds != null) {
+                return model.getSelectedPrimitives().stream()
+                        .map(p -> ds.getPrimitiveById(p.getPrimitiveId())).filter(Objects::nonNull).collect(Collectors.toSet());
+            }
+            return Collections.emptySet();
         }
 
@@ -365 +358 @@
         public void actionPerformed(ActionEvent e) {
             final Set<OsmPrimitive> target = getTarget();
-            if (target == null) {
-                return;
-            } else if (target.isEmpty()) {
+            if (target.isEmpty()) {
                 alertNoPrimitivesTo(model.getSelectedPrimitives(), tr("Nothing to select"),
                         HelpUtil.ht("/Dialog/ChangesetCacheManager#NothingToSelectInLayer"));
@@ -388 +379 @@
         public void actionPerformed(ActionEvent e) {
             final Set<OsmPrimitive> target = getTarget();
-            if (target == null) {
-                return;
-            } else if (target.isEmpty()) {
+            if (target.isEmpty()) {
                 alertNoPrimitivesTo(model.getSelectedPrimitives(), tr("Nothing to zoom to"),
                         HelpUtil.ht("/Dialog/ChangesetCacheManager#NothingToZoomTo"));