Changeset 15998 in josm

Timestamp:

2020-03-02T22:19:23+01:00 (4 years ago)

Author:

simon04

Message:

see #18802 - MapCSSTagChecker: use Stream API

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/validation/tests/MapCSSTagChecker.java (modified) (2 diffs)
• gui/mappaint/Environment.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java

@@ -379 +379 @@
 
         Selector whichSelectorMatchesEnvironment(Environment env) {
-            for (Selector i : rule.selectors) {
-                env.clearSelectorMatchingInformation();
-                if (i.matches(env)) {
-                    return i;
-                }
-            }
-            return null;
+            return rule.selectors.stream()
+                    .filter(i -> i.matches(env.clearSelectorMatchingInformation()))
+                    .findFirst()
+                    .orElse(null);
         }
 
@@ -693 +690 @@
      */
     private static void addIfNotSimilar(TestError toAdd, List<TestError> errors) {
-        boolean isDup = false;
-        if (toAdd.getPrimitives().size() >= 2) {
-            for (TestError e : errors) {
-                if (e.getCode() == toAdd.getCode() && e.getMessage().equals(toAdd.getMessage())
+        final boolean isDup = toAdd.getPrimitives().size() >= 2 && errors.stream()
+                .anyMatch(e -> e.getCode() == toAdd.getCode()
+                        && e.getMessage().equals(toAdd.getMessage())
                         && e.getPrimitives().size() == toAdd.getPrimitives().size()
                         && e.getPrimitives().containsAll(toAdd.getPrimitives())
-                        && highlightedIsEqual(e.getHighlighted(), toAdd.getHighlighted())) {
-                    isDup = true;
-                    break;
-                }
-            }
-        }
+                        && highlightedIsEqual(e.getHighlighted(), toAdd.getHighlighted()));
         if (!isDup)
             errors.add(toAdd);

trunk/src/org/openstreetmap/josm/gui/mappaint/Environment.java

@@ -300 +300 @@
     /**
      * Clears all matching context information
-     */
-    public void clearSelectorMatchingInformation() {
+     * @return this
+     */
+    public Environment clearSelectorMatchingInformation() {
         parent = null;
         child = null;
@@ -309 +310 @@
         intersections = null;
         crossingWaysMap = null;
+        return this;
     }