Changeset 15959 in josm for trunk/test/unit/org/openstreetmap/josm

Timestamp:

2020-02-29T08:07:39+01:00 (4 years ago)

Author:

GerdP

Message:

fix #13165 Validator did not warn about overlapping multipolygons

• let CrossingFinder accept multipolygons
• improve highlighting of overlapping areas
• if incomplete multipolygons are tested the area calculation is used unless open ends are found, else the same algortihm as in CrossingWays is used to hilite the crossing segments. In the later case overlaps with shared nodes are not (yet) found.

File:

• trunk/test/unit/org/openstreetmap/josm/data/validation/tests/MapCSSTagCheckerTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/data/validation/tests/MapCSSTagCheckerTest.java

@@ -357 +357 @@
     }
 
+    /**
+     * Non-regression test for <a href="https://josm.openstreetmap.de/ticket/13165">Bug #13165</a>.
+     * @throws Exception if an error occurs
+     */
+    @Test
+    public void testTicket13165() throws Exception {
+        final MapCSSTagChecker test = buildTagChecker(
+                "area:closed[tag(\"landuse\") = parent_tag(\"landuse\")] ⧉ area:closed[landuse] {"
+                        + "throwWarning: tr(\"Overlapping Identical Landuses\");"
+                        + "}");
+        try (InputStream is = TestUtils.getRegressionDataStream(13165, "13165.osm")) {
+            test.visit(OsmReader.parseDataSet(is, null).allPrimitives());
+            List<TestError> errors = test.getErrors();
+            assertEquals(3, errors.size());
+        }
+    }
+
+    /**
+     * Non-regression test for <a href="https://josm.openstreetmap.de/ticket/13165">Bug #13165</a>.
+     * @throws Exception if an error occurs
+     */
+    @Test
+    public void testTicket13165IncompleteMP() throws Exception {
+        final MapCSSTagChecker test = buildTagChecker(
+                "area:closed[tag(\"landuse\") = parent_tag(\"landuse\")] ⧉ area:closed[landuse] {"
+                        + "throwWarning: tr(\"Overlapping Identical Landuses\");"
+                        + "}");
+        try (InputStream is = TestUtils.getRegressionDataStream(13165, "13165-incomplete.osm.bz2")) {
+            test.visit(OsmReader.parseDataSet(is, null).allPrimitives());
+            List<TestError> errors = test.getErrors();
+            assertEquals(3, errors.size());
+        }
+    }
+
 }