Changeset 15885 in josm for trunk/src/org/openstreetmap/josm/gui

Timestamp:

2020-02-18T23:13:44+01:00 (5 years ago)

Author:

simon04

Message:

fix #18709 - Add Tag Dialog: disable auto completion during use of recent tags

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• dialogs/properties/TagEditHelper.java (modified) (1 diff)
• tagging/ac/AutoCompletingComboBox.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

@@ -938 +938 @@
                     @Override
                     public void actionPerformed(ActionEvent e) {
-                        keys.setSelectedItem(t.getKey());
+                        keys.setSelectedItem(t.getKey(), true);
                         // fix #7951, #8298 - update list of values before setting value (?)
                         focus.focusGained(null);
-                        values.setSelectedItem(t.getValue());
+                        values.setSelectedItem(t.getValue(), true);
                         selectValuesCombobox();
                     }

trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompletingComboBox.java

@@ -12 +12 @@
 import java.util.LinkedList;
 import java.util.Locale;
+import java.util.stream.IntStream;
 
 import javax.swing.ComboBoxEditor;
@@ -257 +258 @@
     /**
      * Selects a given item in the ComboBox model
-     * @param item      excepts AutoCompletionItem, String and null
+     * @param item the item of type AutoCompletionItem, String or null
      */
     @Override
     public void setSelectedItem(Object item) {
+        setSelectedItem(item, false);
+    }
+
+    /**
+     * Selects a given item in the ComboBox model
+     * @param item the item of type AutoCompletionItem, String or null
+     * @param disableAutoComplete if true, autocomplete {@linkplain #setAutocompleteEnabled is disabled} during the operation
+     * @since 15885
+     */
+    public void setSelectedItem(Object item, final boolean disableAutoComplete) {
+        final boolean previousState = isAutocompleteEnabled();
+        if (disableAutoComplete) {
+            // disable autocomplete to prevent unnecessary actions in AutoCompletingComboBoxDocument#insertString
+            setAutocompleteEnabled(false);
+        }
         if (item == null) {
             super.setSelectedItem(null);
@@ -268 +284 @@
             String s = (String) item;
             // find the string in the model or create a new item
-            for (int i = 0; i < getModel().getSize(); i++) {
-                AutoCompletionItem acItem = getModel().getElementAt(i);
-                if (s.equals(acItem.getValue())) {
-                    super.setSelectedItem(acItem);
-                    return;
-                }
-            }
-            super.setSelectedItem(new AutoCompletionItem(s, AutoCompletionPriority.UNKNOWN));
+            AutoCompletionItem acItem = IntStream.range(0, getModel().getSize())
+                    .mapToObj(i -> getModel().getElementAt(i))
+                    .filter(i -> s.equals(i.getValue()))
+                    .findFirst()
+                    .orElseGet(() -> new AutoCompletionItem(s, AutoCompletionPriority.UNKNOWN));
+            super.setSelectedItem(acItem);
         } else {
+            setAutocompleteEnabled(previousState);
             throw new IllegalArgumentException("Unsupported item: "+item);
         }
+        setAutocompleteEnabled(previousState);
     }
 
@@ -293 +309 @@
         }
         this.setSelectedItem(null);
-        // disable autocomplete to prevent unnecessary actions in AutoCompletingComboBoxDocument#insertString
-        autocompleteEnabled = false;
-        this.setSelectedItem(oldValue);
-        autocompleteEnabled = true;
+        this.setSelectedItem(oldValue, true);
     }