Changeset 15845 in josm

Timestamp:

2020-02-12T00:06:43+01:00 (5 years ago)

Author:

simon04

Message:

fix #18703 - Scroll through TabPreferenceSetting using mouse wheel

Location:

trunk/src/org/openstreetmap/josm/gui/preferences

Files:

• DefaultTabPreferenceSetting.java (modified) (1 diff)
• PreferenceTabbedPane.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/DefaultTabPreferenceSetting.java

@@ -49 +49 @@
         this.tabpane = tabpane;
         this.subSettingMap = tabpane != null ? new HashMap<>() : null;
+        if (tabpane != null) {
+            tabpane.addMouseWheelListener(new PreferenceTabbedPane.WheelListener(tabpane));
+        }
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceTabbedPane.java

@@ -79 +79 @@
  * @author imi
  */
-public final class PreferenceTabbedPane extends JTabbedPane implements MouseWheelListener, ExpertModeChangeListener, ChangeListener {
+public final class PreferenceTabbedPane extends JTabbedPane implements ExpertModeChangeListener, ChangeListener {
 
     private final class PluginDownloadAfterTask implements Runnable {
@@ -446 +446 @@
     public PreferenceTabbedPane() {
         super(JTabbedPane.LEFT, JTabbedPane.SCROLL_TAB_LAYOUT);
-        super.addMouseWheelListener(this);
+        super.addMouseWheelListener(new WheelListener(this));
         super.getModel().addChangeListener(this);
         ExpertToggleAction.addExpertModeChangeListener(this);
@@ -578 +578 @@
      * tab strip and scrolls one tab/down or up, selecting it immediately.
      */
-    @Override
-    public void mouseWheelMoved(MouseWheelEvent wev) {
-        // Ensure the cursor is over the tab strip
-        if (super.indexAtLocation(wev.getPoint().x, wev.getPoint().y) < 0)
-            return;
-
-        // Get currently selected tab
-        int newTab = super.getSelectedIndex() + wev.getWheelRotation();
-
-        // Ensure the new tab index is sound
-        newTab = newTab < 0 ? 0 : newTab;
-        newTab = newTab >= super.getTabCount() ? super.getTabCount() - 1 : newTab;
-
-        // select new tab
-        super.setSelectedIndex(newTab);
+    static final class WheelListener implements MouseWheelListener {
+
+        final JTabbedPane tabbedPane;
+
+        WheelListener(JTabbedPane tabbedPane) {
+            this.tabbedPane = tabbedPane;
+        }
+
+        @Override
+        public void mouseWheelMoved(MouseWheelEvent wev) {
+            // Ensure the cursor is over the tab strip
+            if (tabbedPane.indexAtLocation(wev.getPoint().x, wev.getPoint().y) < 0)
+                return;
+
+            // Get currently selected tab && ensure the new tab index is sound
+            int newTab = Utils.clamp(tabbedPane.getSelectedIndex() + wev.getWheelRotation(),
+                    0, tabbedPane.getTabCount() - 1);
+
+            tabbedPane.setSelectedIndex(newTab);
+        }
     }