Changeset 15832 in josm

Timestamp:

2020-02-10T20:46:11+01:00 (4 years ago)

Author:

simon04

Message:

ConflictCollection: use Java 8 features

File:

• trunk/src/org/openstreetmap/josm/data/conflict/ConflictCollection.java (modified) (12 diffs)

trunk/src/org/openstreetmap/josm/data/conflict/ConflictCollection.java

@@ -6 +6 @@
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
@@ -12 +11 @@
 import java.util.Set;
 import java.util.concurrent.CopyOnWriteArrayList;
+import java.util.stream.Collectors;
 
 import org.openstreetmap.josm.data.osm.Node;
@@ -69 +69 @@
 
     protected void fireConflictAdded() {
-        for (IConflictListener listener : listeners) {
-            listener.onConflictsAdded(this);
-        }
+        listeners.forEach(listener -> listener.onConflictsAdded(this));
     }
 
     protected void fireConflictRemoved() {
-        for (IConflictListener listener : listeners) {
-            listener.onConflictsRemoved(this);
-        }
+        listeners.forEach(listener -> listener.onConflictsRemoved(this));
     }
 
@@ -114 +110 @@
     public void add(Collection<Conflict<?>> otherConflicts) {
         if (otherConflicts == null) return;
-        for (Conflict<?> c : otherConflicts) {
-            addConflict(c);
-        }
+        otherConflicts.forEach(this::addConflict);
         fireConflictAdded();
     }
@@ -146 +140 @@
      *
      * @param my  the primitive
-     */
+     * @deprecated use {@link #removeForMy(OsmPrimitive)}
+     */
+    @Deprecated
     public void remove(OsmPrimitive my) {
-        Iterator<Conflict<?>> it = iterator();
-        while (it.hasNext()) {
-            if (it.next().isMatchingMy(my)) {
-                it.remove();
-            }
-        }
-        fireConflictRemoved();
+        removeForMy(my);
     }
 
@@ -166 +156 @@
      */
     public Conflict<?> getConflictForMy(OsmPrimitive my) {
-        for (Conflict<?> c : conflicts) {
-            if (c.isMatchingMy(my))
-                return c;
-        }
-        return null;
+        return conflicts.stream()
+                .filter(c -> c.isMatchingMy(my))
+                .findFirst()
+                .orElse(null);
     }
 
@@ -182 +171 @@
      */
     public Conflict<?> getConflictForTheir(OsmPrimitive their) {
-        for (Conflict<?> c : conflicts) {
-            if (c.isMatchingTheir(their))
-                return c;
-        }
-        return null;
+        return conflicts.stream()
+                .filter(c -> c.isMatchingTheir(their))
+                .findFirst()
+                .orElse(null);
     }
 
@@ -225 +213 @@
      */
     public void removeForMy(OsmPrimitive my) {
-        Iterator<Conflict<?>> it = iterator();
-        while (it.hasNext()) {
-            if (it.next().isMatchingMy(my)) {
-                it.remove();
-            }
+        if (conflicts.removeIf(c -> c.isMatchingMy(my))) {
+            fireConflictRemoved();
         }
     }
@@ -239 +224 @@
      */
     public void removeForTheir(OsmPrimitive their) {
-        Iterator<Conflict<?>> it = iterator();
-        while (it.hasNext()) {
-            if (it.next().isMatchingTheir(their)) {
-                it.remove();
-            }
+        if (conflicts.removeIf(c -> c.isMatchingTheir(their))) {
+            fireConflictRemoved();
         }
     }
@@ -290 +272 @@
      */
     public void add(ConflictCollection other) {
-        for (Conflict<?> c : other) {
-            if (!hasConflict(c)) {
-                add(c);
-            }
-        }
+        other.conflicts.stream()
+                .filter(c -> !hasConflict(c))
+                .forEach(this::add);
     }
 
@@ -305 +285 @@
      */
     public Set<OsmPrimitive> getMyConflictParties() {
-        Set<OsmPrimitive> ret = new HashSet<>();
-        for (Conflict<?> c: conflicts) {
-            ret.add(c.getMy());
-        }
-        return ret;
+        return conflicts.stream()
+                .map(Conflict::getMy)
+                .collect(Collectors.toSet());
     }
 
@@ -320 +298 @@
      */
     public Set<OsmPrimitive> getTheirConflictParties() {
-        Set<OsmPrimitive> ret = new HashSet<>();
-        for (Conflict<?> c: conflicts) {
-            ret.add(c.getTheir());
-        }
-        return ret;
+        return conflicts.stream()
+                .map(Conflict::getTheir)
+                .collect(Collectors.toSet());
     }