Changeset 15497 in josm for trunk/src/org/openstreetmap/josm/data/gpx

Timestamp:

2019-11-02T16:28:02+01:00 (6 years ago)

Author:

Don-vip

Message:

see #16796 - fix most of checkstyle/pmd/findbugs violations

Location:

trunk/src/org/openstreetmap/josm/data/gpx

Files:

• GpxData.java (modified) (1 diff)
• GpxExtension.java (modified) (2 diffs)
• GpxExtensionCollection.java (modified) (1 diff)
• GpxTrack.java (modified) (1 diff)
• IGpxTrack.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/gpx/GpxData.java

@@ -1208 +1208 @@
          * Creates a schema with prefix, URI and location.
          * Does NOT try to determine prefix from URI!
-         * @param prefix
-         * @param uri
-         * @param location
+         * @param prefix XML namespace prefix
+         * @param uri XML namespace URI
+         * @param location XML namespace location
          */
         public XMLNamespace(String prefix, String uri, String location) {

trunk/src/org/openstreetmap/josm/data/gpx/GpxExtension.java

@@ -12 +12 @@
  * @since 15496
  */
-public class GpxExtension extends WithAttributes implements IWithAttributes, GpxConstants {
+public class GpxExtension extends WithAttributes implements GpxConstants {
     private final String qualifiedName, prefix, key;
     private IWithAttributes parent;
@@ -60 +60 @@
     /**
      * Finds the default prefix used by JOSM for the given namespaceURI as the document is free specify another one.
-     * @param namespaceURI
+     * @param namespaceURI namespace URI
      * @return the prefix
      */

trunk/src/org/openstreetmap/josm/data/gpx/GpxExtensionCollection.java

@@ -20 +20 @@
  */
 public class GpxExtensionCollection extends ArrayList<GpxExtension> {
+
+    private static final long serialVersionUID = 1L;
 
     private Stack<GpxExtension> childStack = new Stack<>();

trunk/src/org/openstreetmap/josm/data/gpx/GpxTrack.java

@@ -95 +95 @@
 
     private void setColorExtension(Color color) {
-        getExtensions().findAndRemove("gpxx",  "DisplayColor");
+        getExtensions().findAndRemove("gpxx", "DisplayColor");
         if (color == null) {
-            getExtensions().findAndRemove("gpxd",  "color");
+            getExtensions().findAndRemove("gpxd", "color");
         } else {
             getExtensions().addOrUpdate("gpxd", "color", String.format("#%02X%02X%02X", color.getRed(), color.getGreen(), color.getBlue()));

trunk/src/org/openstreetmap/josm/data/gpx/IGpxTrack.java

@@ -42 +42 @@
     /**
      * Sets the color of this track. Not necessarily supported by all implementations.
-     * @param color
+     * @param color color of this track
      * @since 15496
      */