Changeset 1523 in josm for trunk/src/org/openstreetmap/josm/actions

Timestamp:

2009-04-06T20:18:48+02:00 (16 years ago)

Author:

framm

Message:

• Major redesign of how JOSM talks to the OSM server. Connections now all go through a new OsmApi class that finds out which version the server uses. JOSM should now be able to handle 0.5 and 0.6 without configuration change. Config options osm-server.version and osm-server.additional-versions now obsolete. Handling of error and cancel situations might still need some improvement.

Location:

trunk/src/org/openstreetmap/josm/actions

Files:

• CopyAction.java (modified) (3 diffs)
• HistoryInfoAction.java (modified) (2 diffs)
• ReverseWayAction.java (modified) (2 diffs)
• SaveActionBase.java (modified) (3 diffs)
• SplitWayAction.java (modified) (2 diffs)
• UploadAction.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/CopyAction.java

@@ -8 +8 @@
 import java.awt.event.KeyEvent;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.HashMap;
+import java.util.LinkedList;
 import java.util.List;
-import java.util.LinkedList;
-import java.util.Collection;
 
 import javax.swing.JOptionPane;
@@ -19 +19 @@
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.DataSource;
+import org.openstreetmap.josm.data.osm.Node;
+import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.Relation;
 import org.openstreetmap.josm.data.osm.RelationMember;
-import org.openstreetmap.josm.data.osm.Node;
-import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.Way;
-import org.openstreetmap.josm.data.osm.visitor.Visitor;
+import org.openstreetmap.josm.data.osm.visitor.AbstractVisitor;
 import org.openstreetmap.josm.tools.Shortcut;
 
@@ -65 +65 @@
         /* scan the selected objects, mapping them to copies; when copying a way or relation,
          * the copy references the copies of their child objects */
-        new Visitor(){
+        new AbstractVisitor() {
             public void visit(Node n) {
                 /* check if already in pasteBuffer - e.g. two ways are selected which share a node;

trunk/src/org/openstreetmap/josm/actions/HistoryInfoAction.java

@@ -12 +12 @@
 
 import org.openstreetmap.josm.Main;
-import org.openstreetmap.josm.data.osm.Relation;
 import org.openstreetmap.josm.data.osm.Node;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.data.osm.Relation;
 import org.openstreetmap.josm.data.osm.Way;
-import org.openstreetmap.josm.data.osm.visitor.Visitor;
+import org.openstreetmap.josm.data.osm.visitor.AbstractVisitor;
 import org.openstreetmap.josm.tools.OpenBrowser;
 import org.openstreetmap.josm.tools.Shortcut;
@@ -31 +31 @@
     public void actionPerformed(ActionEvent e) {
         final Collection<Object> sel = new LinkedList<Object>();
-        new Visitor() {
+        new AbstractVisitor() {
             public void visit(Node n) {
                 if(n.id <= 0) return;

trunk/src/org/openstreetmap/josm/actions/ReverseWayAction.java

@@ -19 +19 @@
 import org.openstreetmap.josm.corrector.UserCancelException;
 import org.openstreetmap.josm.data.osm.DataSet;
-import org.openstreetmap.josm.data.osm.Relation;
 import org.openstreetmap.josm.data.osm.Node;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.data.osm.Relation;
 import org.openstreetmap.josm.data.osm.Way;
-import org.openstreetmap.josm.data.osm.visitor.Visitor;
+import org.openstreetmap.josm.data.osm.visitor.AbstractVisitor;
 import org.openstreetmap.josm.tools.Shortcut;
 
@@ -35 +35 @@
     public void actionPerformed(ActionEvent e) {
         final Collection<Way> sel = new LinkedList<Way>();
-        new Visitor() {
+        new AbstractVisitor() {
             public void visit(Node n) {
             }

trunk/src/org/openstreetmap/josm/actions/SaveActionBase.java

@@ -6 +6 @@
 import java.awt.event.ActionEvent;
 import java.io.File;
-import java.io.FileOutputStream;
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
 import java.io.IOException;
+import java.io.PrintWriter;
 
 import javax.swing.JFileChooser;
@@ -18 +19 @@
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.gui.ExtendedDialog;
+import org.openstreetmap.josm.gui.layer.GpxLayer;
+import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
-import org.openstreetmap.josm.gui.layer.Layer;
-import org.openstreetmap.josm.gui.layer.GpxLayer;
+import org.openstreetmap.josm.io.GpxWriter;
 import org.openstreetmap.josm.io.OsmWriter;
-import org.openstreetmap.josm.io.GpxWriter;
 import org.openstreetmap.josm.tools.Shortcut;
 
@@ -159 +160 @@
                     copy(file, tmpFile);
                 }
-                OsmWriter.output(new FileOutputStream(file), new OsmWriter.All(layer.data, false));
+                OsmWriter w = new OsmWriter(new PrintWriter(new FileOutputStream(file)), false, layer.data.version);
+                w.header();
+                w.writeDataSources(layer.data);
+                w.writeContent(layer.data);
+                w.footer();
+                // FIXME - how to close?
                 if (!Main.pref.getBoolean("save.keepbackup") && (tmpFile != null))
                     tmpFile.delete();

trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java

@@ -31 +31 @@
 import org.openstreetmap.josm.data.osm.RelationMember;
 import org.openstreetmap.josm.data.osm.Way;
+import org.openstreetmap.josm.data.osm.visitor.AbstractVisitor;
 import org.openstreetmap.josm.data.osm.visitor.NameVisitor;
 import org.openstreetmap.josm.data.osm.visitor.Visitor;
@@ -74 +75 @@
         selectedNodes = null;
 
-        Visitor splitVisitor = new Visitor(){
+        Visitor splitVisitor = new AbstractVisitor() {
             public void visit(Node n) {
                 if (selectedNodes == null)

trunk/src/org/openstreetmap/josm/actions/UploadAction.java

@@ -154 +154 @@
         PleaseWaitRunnable uploadTask = new PleaseWaitRunnable(tr("Uploading data")){
             @Override protected void realRun() throws SAXException {
-                server.uploadOsm(all);
+                server.uploadOsm(Main.ds.version, all);
             }
             @Override protected void finish() {
@@ -160 +160 @@
             }
             @Override protected void cancel() {
-                server.cancel();
+                // FIXME server.cancel();
             }
         };