Changeset 15133 in josm for trunk

Timestamp:

2019-05-28T20:00:36+02:00 (5 years ago)

Author:

GerdP

Message:

see #17765: Further simplify code

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java

@@ -8 +8 @@
 import java.util.Collections;
 import java.util.HashSet;
-import java.util.List;
 import java.util.Set;
 
-import org.openstreetmap.josm.data.osm.Node;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.OsmUtils;
@@ -195 +193 @@
         }
         // code 1131: other area style ways
-        if (ElemStyles.hasOnlyAreaElements(w)) {
-            List<Node> nodes = w.getNodes();
-            if (nodes.isEmpty()) return; // fix zero nodes bug
+        if (ElemStyles.hasOnlyAreaElements(w) && !w.getNodes().isEmpty()) {
             errors.add(TestError.builder(this, Severity.WARNING, 1131)
                     .message(tr("Unclosed way"), marktr("Area style way is not closed"), new Object())