Changeset 15036 in josm

Timestamp:

2019-05-02T08:54:58+02:00 (6 years ago)

Author:

GerdP

Message:

see #17616: fix findbugs issues FE_FLOATING_POINT_EQUALITY

File:

• trunk/src/org/openstreetmap/josm/tools/Geometry.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/tools/Geometry.java

@@ -1156 +1156 @@
             double distance = getDistance(osm, primitive);
             if (Double.isNaN(distance)) continue;
-            if (distance < lowestDistance) {
+            int comp = Double.compare(distance, lowestDistance);
+            if (comp < 0) {
                 closest.clear();
                 lowestDistance = distance;
                 closest.add(primitive);
-            } else if (distance == lowestDistance) {
+            } else if (comp == 0) {
                 closest.add(primitive);
             }
@@ -1219 +1220 @@
             double distance = getDistance(osm, primitive);
             if (Double.isNaN(distance)) continue;
-            if (distance > furthestDistance) {
+            int comp = Double.compare(distance, furthestDistance);
+            if (comp > 0) {
                 furthest.clear();
                 furthestDistance = distance;
                 furthest.add(primitive);
-            } else if (distance == furthestDistance) {
+            } else if (comp == 0) {
                 furthest.add(primitive);
             }