Changeset 14640 in josm for trunk/src

Timestamp:

2019-01-04T23:44:59+01:00 (5 years ago)

Author:

simon04

Message:

fix #17169 - Missing MessageFormat arguments in OptionParser

File:

• trunk/src/org/openstreetmap/josm/tools/OptionParser.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/tools/OptionParser.java

@@ -42 +42 @@
     public OptionParser addShortAlias(String optionName, String shortName) {
         if (!shortName.matches("\\w")) {
-            throw new IllegalArgumentException("Short name " + shortName + " must be one character");
+            throw new IllegalArgumentException("Short name '" + shortName + "' must be one character");
         }
         if (availableOptions.containsKey("-" + shortName)) {
-            throw new IllegalArgumentException("Short name " + shortName + " is already used");
+            throw new IllegalArgumentException("Short name '" + shortName + "' is already used");
         }
         AvailableOption longDefinition = availableOptions.get("--" + optionName);
@@ -70 +70 @@
     private void checkOptionName(String optionName) {
         if (!optionName.matches("\\w([\\w-]*\\w)?")) {
-            throw new IllegalArgumentException("Illegal option name: " + optionName);
+            throw new IllegalArgumentException("Illegal option name: '" + optionName + "'");
         }
         if (availableOptions.containsKey("--" + optionName)) {
-            throw new IllegalArgumentException("The option --" + optionName + " is already registered");
+            throw new IllegalArgumentException("The option '--" + optionName + "' is already registered");
         }
     }
@@ -164 +164 @@
                     } else {
                         if (toHandle.isEmpty() || "--".equals(toHandle.getFirst())) {
-                            throw new OptionParseException(tr("{0}: option ''{1}'' requires an argument", program));
+                            throw new OptionParseException(tr("{0}: option ''{1}'' requires an argument", program, optionName));
                         }
                         parameter = toHandle.removeFirst();
@@ -179 +179 @@
         availableOptions.values().stream().distinct().forEach(def -> {
             long count = options.stream().filter(p -> def.equals(p.option)).count();
+            String optionName = availableOptions.entrySet().stream()
+                    .filter(entry -> def.equals(entry.getValue()))
+                    .map(Entry::getKey)
+                    .findFirst()
+                    .orElse("?");
             if (count < def.getRequiredCount().min) {
                 // min may be 0 or 1 at the moment
-                throw new OptionParseException(tr("{0}: option ''{1}'' is required"));
+                throw new OptionParseException(tr("{0}: option ''{1}'' is required", program, optionName));
             } else if (count > def.getRequiredCount().max) {
                 // max may be 1 or MAX_INT at the moment
-                throw new OptionParseException(tr("{0}: option ''{1}'' may not appear multiple times"));
+                throw new OptionParseException(tr("{0}: option ''{1}'' may not appear multiple times", program, optionName));
             }
         });
@@ -222 +227 @@
                 return alternatives.get(0);
             } else if (alternatives.size() > 1) {
-                throw new OptionParseException(tr("{0}: option ''{1}'' is ambiguous", program));
+                throw new OptionParseException(tr("{0}: option ''{1}'' is ambiguous", program, optionName));
             }
         }