Changeset 14585 in josm

Timestamp:

2018-12-22T11:35:27+01:00 (5 years ago)

Author:

GerdP

Message:

see #17055 Disable autofix for possibly misspelled tag values

Some keys like shop have a long list of documented values and not all are in the presets. It can happen that a good value is flagged and a fix and an improper fix value is suggested.
This should be reverted once we have a better source for "correct" values. The presets are too incomplete.

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/validation/tests/TagChecker.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/data/validation/tests/TagCheckerTest.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -591 +591 @@
                                         marktr("Value ''{0}'' for key ''{1}'' looks like ''{2}''."), prop.getValue(), key, newValue)
                                 .primitives(p)
-                                .fix(() -> new ChangePropertyCommand(p, key, newValue))
                                 .build());
                         withErrors.put(p, "WPV");
@@ -781 +780 @@
             int code = testError.getCode();
             return code == INVALID_KEY || code == EMPTY_VALUES || code == INVALID_SPACE ||
-                   code == INVALID_KEY_SPACE || code == INVALID_HTML || code == MISSPELLED_VALUE ||
+                   code == INVALID_KEY_SPACE || code == INVALID_HTML ||
                    code == MULTIPLE_SPACES;
         }

trunk/test/unit/org/openstreetmap/josm/data/validation/tests/TagCheckerTest.java

@@ -108 +108 @@
         assertEquals("Value 'forrest' for key 'landuse' looks like 'forest'.", errors.get(0).getDescription());
         assertEquals(Severity.WARNING, errors.get(0).getSeverity());
-        assertTrue(errors.get(0).isFixable());
+        assertFalse(errors.get(0).isFixable());
     }
 
@@ -136 +136 @@
         assertEquals("Value 'residentail' for key 'highway' looks like 'residential'.", errors.get(0).getDescription());
         assertEquals(Severity.WARNING, errors.get(0).getSeverity());
-        assertTrue(errors.get(0).isFixable());
+        assertFalse(errors.get(0).isFixable());
     }
 
@@ -208 +208 @@
         assertEquals("Value 'Residential' for key 'highway' looks like 'residential'.", errors.get(0).getDescription());
         assertEquals(Severity.WARNING, errors.get(0).getSeverity());
-        assertTrue(errors.get(0).isFixable());
+        assertFalse(errors.get(0).isFixable());
     }