Changeset 14559 in josm

Timestamp:

2018-12-14T15:19:21+01:00 (5 years ago)

Author:

GerdP

Message:

fix #17108 avoid duplicate warning for unclosed ways which are also tested in geometry.mapcss rule "{0} on a way, should be a node"

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java

@@ -135 +135 @@
     private static final UnclosedWaysCheck[] checks = {
         // CHECKSTYLE.OFF: SingleSpaceSeparator
-        new UnclosedWaysCheck(1101, "natural",   marktr("natural type {0}"),
-                new HashSet<>(Arrays.asList("cave", "coastline", "cliff", "tree_row", "ridge", "valley", "arete", "gorge", "gully"))),
-        new UnclosedWaysCheck(1102, "landuse",   marktr("landuse type {0}")),
+        // list contains natural tag allowed on unclosed ways as well as those only allowed on nodes to avoid
+        // duplicate warnings
+        new UnclosedWaysCheck(1101, "natural", marktr("natural type {0}"),
+            new HashSet<>(Arrays.asList("arete", "cave", "cliff", "coastline", "gorge", "gully", "peak",
+                            "ridge", "saddle", "tree", "tree_row", "valley", "volcano"))),
+
+        new UnclosedWaysCheck(1102, "landuse", marktr("landuse type {0}")),
         new UnclosedWaysCheck(1103, "amenities", marktr("amenities type {0}")),
         new UnclosedWaysCheck(1104, "sport",     marktr("sport type {0}"),