Changeset 14437 in josm for trunk/test

Timestamp:

2018-11-20T17:01:47+01:00 (5 years ago)

Author:

GerdP

Message:

fix #17010 - Validator creates multiple errors/warnings for same problem

The fix reduces the noise.

• Don't check roles again in RelationChecker when MultipolygonTest is enabled
• remove special code that just searches for an outer way
• correct checkMembersAndRoles, it did not find wrong roles for way members

File:

• trunk/test/unit/org/openstreetmap/josm/data/validation/tests/RelationCheckerTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/data/validation/tests/RelationCheckerTest.java

@@ -47 +47 @@
     @Test
     public void testUnknownType() {
-        List<TestError> errors = testRelation(createRelation("type=foobar"));
+        Relation r = createRelation("type=foobar");
+        r.addMember(new RelationMember("", new Way()));
+        List<TestError> errors = testRelation(r);
+
         assertTrue(errors.size() >= 1);
         assertEquals("Relation type is unknown", errors.get(0).getMessage());