Changeset 14349 in josm

Timestamp:

2018-10-19T01:14:24+02:00 (7 years ago)

Author:

Don-vip

Message:

fix #16855 - OsmDataLayerTest: fix for non-headless mode (patch by ris)

Location:

trunk

Files:

• src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/gui/layer/OsmDataLayerTest.java (modified) (3 diffs)
• test/unit/org/openstreetmap/josm/gui/layer/gpx/ChooseTrackVisibilityActionTest.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java

@@ -11 +11 @@
 import java.awt.Composite;
 import java.awt.Graphics2D;
-import java.awt.GraphicsEnvironment;
 import java.awt.GridBagLayout;
 import java.awt.Rectangle;
@@ -1103 +1102 @@
     public boolean checkSaveConditions() {
         if (isDataSetEmpty() && 1 != GuiHelper.runInEDTAndWaitAndReturn(() -> {
-            if (GraphicsEnvironment.isHeadless()) {
-                return 2;
-            }
             return new ExtendedDialog(
                     MainApplication.getMainFrame(),

trunk/test/unit/org/openstreetmap/josm/gui/layer/OsmDataLayerTest.java

@@ -35 +35 @@
 import org.openstreetmap.josm.io.OsmReader;
 import org.openstreetmap.josm.testutils.JOSMTestRules;
+import org.openstreetmap.josm.testutils.mockers.ExtendedDialogMocker;
 import org.openstreetmap.josm.tools.date.DateUtils;
+
+import com.google.common.collect.ImmutableMap;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
@@ -280 +283 @@
     @Test
     public void testCheckSaveConditions() {
+        TestUtils.assumeWorkingJMockit();
+        final ExtendedDialogMocker edMocker = new ExtendedDialogMocker(
+            ImmutableMap.<String, Object>of("The document contains no data.", "Cancel")
+        );
+
         assertFalse(layer.checkSaveConditions());
         fillDataSet(ds);
         assertTrue(layer.checkSaveConditions());
-    }
-
+
+        assertEquals(1, edMocker.getInvocationLog().size());
+        Object[] invocationLogEntry = edMocker.getInvocationLog().get(0);
+        assertEquals(2, (int) invocationLogEntry[0]);
+        assertEquals("Empty document", invocationLogEntry[2]);
+    }
+
+    /**
+     * Checks that unnamed layer number increases
+     */
     @Test
     public void testLayerNameIncreases() throws Exception {
@@ -293 +309 @@
     }
 
+    /**
+     * Checks that named layer got no number
+     */
     @Test
     public void testLayerUnnumberedName() {

trunk/test/unit/org/openstreetmap/josm/gui/layer/gpx/ChooseTrackVisibilityActionTest.java

@@ -9 +9 @@
 import org.junit.Rule;
 import org.junit.Test;
+import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.gui.ExtendedDialog;
 import org.openstreetmap.josm.gui.layer.GpxLayerTest;
@@ -34 +35 @@
     @Test
     public void testAction() throws Exception {
+        TestUtils.assumeWorkingJMockit();
         final ExtendedDialogMocker edMocker = new ExtendedDialogMocker() {
+            @Override
             protected String getString(final ExtendedDialog instance) {
                 return ((JLabel) ((JPanel) this.getContent(instance)).getComponent(2)).getText();