Changeset 14268 in josm for trunk/src/org/openstreetmap

Timestamp:

2018-09-22T00:00:37+02:00 (6 years ago)

Author:

wiktorn

Message:

Retry tile download on transient errors.

Till now there was no strategy to retry tile download. Tiles for which download
finished with error where by design not downloaded again. Because we were
issuing surplus download requests it was not easy to notice, that some tiles
where downloaded at different zoom level. When surplus downloads where removed -
problem became aparent.

Redefine semantics in AbstractTileSourceLayer, that all Tiles that are not
loaded are tried again. Move all logic deciding whether tile has loaded or not
to TMSCachedTileLoaderJob.

Implment in TMSCachedTileLoaderJob following rules:

• when HTTP status code is between 400 and 500 - treat errors as permament
• when HTTP status code equals or is greater than 500 - then treat error as

temporary

• when there was exception in JCSCachedTileLoaderJob, then HTTP status code is

set to 599. Treat this as permament error. This is suboptimal, as we could treat
Socket read timeout and similar as temporary, and UnkownHostException as
permament

The other aproach is to implement retry count in Tile and retry for finite
number of times, preferably with some delay between tries.

Closes: #16747
See: #16743

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/imagery/TMSCachedTileLoaderJob.java (modified) (3 diffs)
• gui/layer/AbstractTileSourceLayer.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java

@@ -181 +181 @@
                     int httpStatusCode = attributes.getResponseCode();
                     if (httpStatusCode >= 400 && !isNoTileAtZoom()) {
-                        if (attributes.getErrorMessage() == null) {
-                            tile.setError(tr("HTTP error {0} when loading tiles", httpStatusCode));
-                        } else {
-                            tile.setError(tr("Error downloading tiles: {0}", attributes.getErrorMessage()));
-                        }
                         status = false;
+                        handleError(attributes);
                     }
                 }
@@ -192 +188 @@
                 break;
             case FAILURE:
-                tile.setError("Problem loading tile");
+                handleError(attributes);
                 tryLoadTileImage(object);
                 break;
@@ -215 +211 @@
                 }
             }
+        }
+    }
+
+    private void handleError(CacheEntryAttributes attributes) {
+        if (attributes != null) {
+            int httpStatusCode = attributes.getResponseCode();
+            if (attributes.getErrorMessage() == null) {
+                tile.setError(tr("HTTP error {0} when loading tiles", httpStatusCode));
+            } else {
+                tile.setError(tr("Error downloading tiles: {0}", attributes.getErrorMessage()));
+            }
+            if (httpStatusCode >= 500 && httpStatusCode != 599) {
+                // httpStatusCode = 599 is set by JCSCachedTileLoaderJob on IOException
+                tile.setLoaded(false); // treat 500 errors as temporary and try to load it again
+            }
+        } else {
+            tile.setError(tr("Problem loading tile"));
+            // treat unknown errors as permanent and do not try to load tile again
         }
     }

trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java

@@ -303 +303 @@
             tile.setImage(null);
         }
-        tile.setLoaded(success);
         invalidateLater();
         Logging.debug("tileLoadingFinished() tile: {0} success: {1}", tile, success);
@@ -461 +460 @@
                     }
                 }
+                content.add(Arrays.asList(tr("Status:"), tr(tile.getStatus())));
+                content.add(Arrays.asList(tr("Loaded:"), tr(Boolean.toString(tile.isLoaded()))));
+                content.add(Arrays.asList(tr("Loading:"), tr(Boolean.toString(tile.isLoading()))));
+                content.add(Arrays.asList(tr("Error:"), tr(Boolean.toString(tile.hasError()))));
                 for (List<String> entry: content) {
                     panel.add(new JLabel(entry.get(0) + ':'), GBC.std());
@@ -889 +892 @@
         if (tile == null)
             return false;
-        if (!force && (tile.isLoaded() || tile.hasError()))
+        if (!force && tile.isLoaded())
             return false;
         if (tile.isLoading())