Changeset 14252 in josm for trunk/src

Timestamp:

2018-09-16T01:54:22+02:00 (6 years ago)

Author:

Don-vip

Message:

one file missed

File:

• trunk/src/org/openstreetmap/josm/actions/UploadAction.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/UploadAction.java

@@ -31 +31 @@
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.gui.util.GuiHelper;
+import org.openstreetmap.josm.io.UploadStrategySpecification;
 import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.tools.ImageProvider;
@@ -246 +247 @@
         dialog.setVisible(true);
         dialog.rememberUserInput();
-        if (dialog.isCanceled())
-            return;
+        if (dialog.isCanceled()) {
+            dialog.clean();
+            return;
+        }
 
         for (UploadHook hook : LATE_UPLOAD_HOOKS) {
-            if (!hook.checkUpload(apiData))
+            if (!hook.checkUpload(apiData)) {
+                dialog.clean();
                 return;
+            }
         }
 
         // Any hooks want to change the changeset tags?
-        Changeset cs = UploadDialog.getUploadDialog().getChangeset();
+        Changeset cs = dialog.getChangeset();
         Map<String, String> changesetTags = cs.getKeys();
         for (UploadHook hook : UPLOAD_HOOKS) {
@@ -264 +269 @@
         }
 
+        UploadStrategySpecification uploadStrategySpecification = dialog.getUploadStrategySpecification();
+        dialog.clean();
+
         if (Config.getPref().getBoolean(IS_ASYNC_UPLOAD_ENABLED, true)) {
             Optional<AsynchronousUploadPrimitivesTask> asyncUploadTask = AsynchronousUploadPrimitivesTask.createAsynchronousUploadTask(
-                    UploadDialog.getUploadDialog().getUploadStrategySpecification(),
-                    layer,
-                    apiData,
-                    cs);
+                    uploadStrategySpecification, layer, apiData, cs);
 
             if (asyncUploadTask.isPresent()) {
@@ -275 +280 @@
             }
         } else {
-            MainApplication.worker.execute(
-                    new UploadPrimitivesTask(
-                            UploadDialog.getUploadDialog().getUploadStrategySpecification(),
-                            layer,
-                            apiData,
-                            cs));
+            MainApplication.worker.execute(new UploadPrimitivesTask(uploadStrategySpecification, layer, apiData, cs));
         }
     }