Changeset 14251 in josm

Timestamp:

2018-09-16T01:46:08+02:00 (6 years ago)

Author:

Don-vip

Message:

fix memory leaks after upload, validation and primitives combining

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• conflict/tags/CombinePrimitiveResolverDialog.java (modified) (3 diffs)
• dialogs/validator/ValidatorTreePanel.java (modified) (1 diff)
• io/UploadDialog.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java

@@ -539 +539 @@
                 dialog.setVisible(true);
                 if (!dialog.isApplied()) {
+                    dialog.dispose();
                     return new UserCancelException();
                 }
@@ -547 +548 @@
                     cmds.addAll(dialog.buildResolutionCommands());
                 }
+                dialog.dispose();
                 return null;
             });
@@ -632 +634 @@
         return tr("{0} ({1})", key, values);
     }
+
+    @Override
+    public void dispose() {
+        setTargetPrimitive(null, false);
+        super.dispose();
+    }
 }

trunk/src/org/openstreetmap/josm/gui/dialogs/validator/ValidatorTreePanel.java

@@ -409 +409 @@
     @Override
     public void destroy() {
+        DatasetEventManager.getInstance().removeDatasetListener(this);
         DataSet ds = MainApplication.getLayerManager().getActiveDataSet();
         if (ds != null) {

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -259 +259 @@
     public void setUploadedPrimitives(APIDataSet toUpload) {
         if (toUpload == null) {
-            List<OsmPrimitive> emptyList = Collections.emptyList();
-            pnlUploadedObjects.setUploadedPrimitives(emptyList, emptyList, emptyList);
+            if (pnlUploadedObjects != null) {
+                List<OsmPrimitive> emptyList = Collections.emptyList();
+                pnlUploadedObjects.setUploadedPrimitives(emptyList, emptyList, emptyList);
+            }
             return;
         }
@@ -698 +700 @@
     }
 
+    /**
+     * Clean dialog state and release resources.
+     * @since 14251
+     */
+    public void clean() {
+        setUploadedPrimitives(null);
+        pnlBasicUploadSettings = null;
+        pnlChangesetManagement = null;
+        pnlTagSettings = null;
+        pnlUploadedObjects = null;
+        pnlUploadStrategySelectionPanel = null;
+        tpConfigPanels = null;
+        btnUpload = null;
+        dataSet = null;
+    }
 }