Changeset 14209 in josm

Timestamp:

2018-08-31T21:59:54+02:00 (6 years ago)

Author:

Don-vip

Message:

see #16681 - spotbugs / pmd

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/gpx/GpxImageCorrelation.java (modified) (2 diffs)
• src/org/openstreetmap/josm/data/gpx/GpxImageEntry.java (modified) (2 diffs)
• src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/data/gpx/GpxImageEntryTest.java (added)
• tools/pmd/josm-ruleset.xml (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/gpx/GpxImageCorrelation.java

@@ -62 +62 @@
                 segs.sort(new Comparator<List<WayPoint>>() {
                     @Override
-                    public int compare(List<WayPoint> arg0, List<WayPoint> arg1) {
-                        if (arg0.isEmpty() || arg1.isEmpty() || arg0.get(0).time == arg1.get(0).time)
+                    public int compare(List<WayPoint> o1, List<WayPoint> o2) {
+                        if (o1.isEmpty() || o2.isEmpty())
                             return 0;
-                        return arg0.get(0).time < arg1.get(0).time ? -1 : 1;
+                        return Double.compare(o1.get(0).time, o2.get(0).time);
                     }
                 });
@@ -74 +74 @@
         trks.sort(new Comparator<List<List<WayPoint>>>() {
             @Override
-            public int compare(List<List<WayPoint>> arg0, List<List<WayPoint>> arg1) {
-                if (arg0.isEmpty() || arg0.get(0).isEmpty()
-                        || arg1.isEmpty() || arg1.get(0).isEmpty()
-                        || arg0.get(0).get(0).time == arg1.get(0).get(0).time)
+            public int compare(List<List<WayPoint>> o1, List<List<WayPoint>> o2) {
+                if (o1.isEmpty() || o1.get(0).isEmpty()
+                 || o2.isEmpty() || o2.get(0).isEmpty())
                     return 0;
-                return arg0.get(0).get(0).time < arg1.get(0).get(0).time ? -1 : 1;
+                return Double.compare(o1.get(0).get(0).time, o2.get(0).get(0).time);
             }
         });

trunk/src/org/openstreetmap/josm/data/gpx/GpxImageEntry.java

@@ -5 +5 @@
 import java.io.IOException;
 import java.util.Date;
+import java.util.Objects;
 
 import org.openstreetmap.josm.data.coor.CachedLatLon;
@@ -332 +333 @@
     }
 
+    @Override
+    public int hashCode() {
+        return Objects.hash(height, width, isNewGpsData,
+            elevation, exifCoor, exifGpsTime, exifImgDir, exifOrientation, exifTime,
+            file, gpsTime, pos, speed, tmp);
+    }
+
+    @Override
+    public boolean equals(Object obj) {
+        if (this == obj)
+            return true;
+        if (obj == null || getClass() != obj.getClass())
+            return false;
+        GpxImageEntry other = (GpxImageEntry) obj;
+        return height == other.height
+            && width == other.width
+            && isNewGpsData == other.isNewGpsData
+            && Objects.equals(elevation, other.elevation)
+            && Objects.equals(exifCoor, other.exifCoor)
+            && Objects.equals(exifGpsTime, other.exifGpsTime)
+            && Objects.equals(exifImgDir, other.exifImgDir)
+            && Objects.equals(exifOrientation, other.exifOrientation)
+            && Objects.equals(exifTime, other.exifTime)
+            && Objects.equals(file, other.file)
+            && Objects.equals(gpsTime, other.gpsTime)
+            && Objects.equals(pos, other.pos)
+            && Objects.equals(speed, other.speed)
+            && Objects.equals(tmp, other.tmp);
+    }
+
     /**
      * Make a fresh copy and save it in the temporary variable. Use

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java

@@ -111 +111 @@
 public class CorrelateGpxWithImages extends AbstractAction {
 
-    private static List<GpxData> loadedGpxData = new ArrayList<>();
+    private static final List<GpxData> loadedGpxData = new ArrayList<>();
 
     private final transient GeoImageLayer yLayer;
     private transient GpxTimezone timezone;
     private transient GpxTimeOffset delta;
-    private static boolean forceTags = false;
+    private static boolean forceTags;
 
     /**

trunk/tools/pmd/josm-ruleset.xml

@@ -156 +156 @@
     <exclude name="AvoidLiteralsInIfCondition"/>
     <exclude name="BeanMembersShouldSerialize"/>
+    <exclude name="CloneThrowsCloneNotSupportedException"/>
     <exclude name="CompareObjectsWithEquals"/>
     <exclude name="ConstructorCallsOverridableMethod"/>