Changeset 14128 in josm for trunk/src/org

Timestamp:

2018-08-11T19:19:44+02:00 (6 years ago)

Author:

Don-vip

Message:

see #15229 - deprecate Main.fileWatcher

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (1 diff)
• data/validation/tests/MapCSSTagChecker.java (modified) (3 diffs)
• gui/MainApplication.java (modified) (1 diff)
• gui/mappaint/MapPaintStyles.java (modified) (3 diffs)
• io/FileWatcher.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/Main.java

@@ -77 +77 @@
     /**
      * The file watcher service.
-     */
-    public static final FileWatcher fileWatcher = new FileWatcher();
+     * @deprecated Use {@link FileWatcher#getDefaultInstance}
+     */
+    @Deprecated
+    public static final FileWatcher fileWatcher = FileWatcher.getDefaultInstance();
 
     /**

trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java

@@ -29 +29 @@
 import java.util.regex.Pattern;
 
-import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.command.ChangePropertyCommand;
 import org.openstreetmap.josm.command.ChangePropertyKeyCommand;
@@ -62 +61 @@
 import org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.TokenMgrError;
 import org.openstreetmap.josm.io.CachedFile;
+import org.openstreetmap.josm.io.FileWatcher;
 import org.openstreetmap.josm.io.IllegalDataException;
 import org.openstreetmap.josm.io.UTFInputStreamReader;
@@ -762 +762 @@
                 addMapCSS(i);
                 if (Config.getPref().getBoolean("validator.auto_reload_local_rules", true) && source.isLocal()) {
-                    Main.fileWatcher.registerSource(source);
+                    FileWatcher.getDefaultInstance().registerSource(source);
                 }
             } catch (IOException | IllegalStateException | IllegalArgumentException ex) {

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -410 +410 @@
     protected List<InitializationTask> beforeInitializationTasks() {
         return Arrays.asList(
-            new InitializationTask(tr("Starting file watcher"), fileWatcher::start),
+            new InitializationTask(tr("Starting file watcher"), FileWatcher.getDefaultInstance()::start),
             new InitializationTask(tr("Executing platform startup hook"), () -> platform.startupHook(MainApplication::askUpdateJava)),
             new InitializationTask(tr("Building main menu"), this::initializeMainWindow),

trunk/src/org/openstreetmap/josm/gui/mappaint/MapPaintStyles.java

@@ -15 +15 @@
 import javax.swing.SwingUtilities;
 
-import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.coor.LatLon;
 import org.openstreetmap.josm.data.osm.DataSet;
@@ -27 +26 @@
 import org.openstreetmap.josm.gui.mappaint.styleelement.StyleElement;
 import org.openstreetmap.josm.io.CachedFile;
+import org.openstreetmap.josm.io.FileWatcher;
 import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.tools.ImageProvider;
@@ -327 +327 @@
         if (Config.getPref().getBoolean("mappaint.auto_reload_local_styles", true) && source.isLocal()) {
             try {
-                Main.fileWatcher.registerSource(source);
+                FileWatcher.getDefaultInstance().registerSource(source);
             } catch (IOException | IllegalStateException | IllegalArgumentException e) {
                 Logging.error(e);

trunk/src/org/openstreetmap/josm/io/FileWatcher.java

@@ -34 +34 @@
     private static final Map<SourceType, Consumer<SourceEntry>> loaderMap = new EnumMap<>(SourceType.class);
     private final Map<Path, SourceEntry> sourceMap = new HashMap<>();
+
+    private static class InstanceHolder {
+        static final FileWatcher INSTANCE = new FileWatcher();
+    }
+
+    /**
+     * Returns the default instance.
+     * @return the default instance
+     * @since 14128
+     */
+    public static FileWatcher getDefaultInstance() {
+        return InstanceHolder.INSTANCE;
+    }
 
     /**