Changeset 14108 in josm

Timestamp:

2018-08-08T21:05:54+02:00 (6 years ago)

Author:

Don-vip

Message:

SonarQube fixes

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/io/importexport/OsmChangeImporter.java (modified) (1 diff)
• gui/layer/gpx/ConvertToDataLayerAction.java (modified) (1 diff)
• io/OsmJsonReader.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/io/importexport/OsmChangeImporter.java

@@ -76 +76 @@
         if (!hasOsmData && !hasNotes) {
             // FIXME: remove UI stuff from IO subsystem
-            GuiHelper.runInEDT(() -> {
+            GuiHelper.runInEDT(() ->
                 JOptionPane.showMessageDialog(
                         Main.parent,
                         tr("No data found in file {0}.", associatedFile.getPath()),
                         tr("Open OsmChange file"),
-                        JOptionPane.INFORMATION_MESSAGE);
-            });
+                        JOptionPane.INFORMATION_MESSAGE)
+            );
         }
     }

trunk/src/org/openstreetmap/josm/gui/layer/gpx/ConvertToDataLayerAction.java

@@ -196 +196 @@
          * @return {@link TagConversionDialogResponse} containing the selection
          */
-        private TagConversionDialogResponse showTagConversionDialog(List<String> keys, List<String> listPos, List<String> listNeg) {
+        private static TagConversionDialogResponse showTagConversionDialog(List<String> keys, List<String> listPos, List<String> listNeg) {
             TagConversionDialogResponse res = new TagConversionDialogResponse(listPos, listNeg);
             String lSel = Config.getPref().get(GPX_SETTING + ".last", "all");

trunk/src/org/openstreetmap/josm/io/OsmJsonReader.java

@@ -139 +139 @@
     }
 
-    private void readWayNodesAndTags(JsonObject item, Way w, Collection<Long> nodeIds) {
+    private static void readWayNodesAndTags(JsonObject item, Way w, Collection<Long> nodeIds) {
         for (JsonValue v : item.getJsonArray("nodes")) {
             nodeIds.add(((JsonNumber) v).longValue());