Changeset 14070 in josm for trunk/src

Timestamp:

2018-08-01T19:21:43+02:00 (6 years ago)

Author:

Don-vip

Message:

fix #16547 - Display log messages with log levels warn and higher in the console (patch by floscher)

File:

• trunk/src/org/openstreetmap/josm/tools/Logging.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/tools/Logging.java

@@ -62 +62 @@
         private final Handler prioritizedHandler;
         private OutputStream outputStreamMemo;
+        /**
+         * This variables is set to true as soon as the superconstructor has completed.
+         * The superconstructor calls {@code setOutputStream(System.err)}, any subsequent call of
+         * {@link #setOutputStream(OutputStream)} would then flush and close {@link System#err}. To avoid this,
+         * we override {@link #setOutputStream(OutputStream)} to completely ignore all calls from the superconstructor.
+         */
+        private boolean superCompleted = false;
 
         /**
@@ -76 +83 @@
             final Handler prioritizedHandler
         ) {
+            super();
+            superCompleted = true;
             this.outputStreamSupplier = outputStreamSupplier;
             this.prioritizedHandler = prioritizedHandler;
@@ -98 +107 @@
         @Override
         public synchronized void setOutputStream(final OutputStream outputStream) {
-            // this wouldn't be necessary if StreamHandler made it possible to see what the current
-            // output stream is set to
-            this.outputStreamMemo = outputStream;
-            super.setOutputStream(outputStream);
+            // Ignore calls from superconstructor (see javadoc of the variable for details)
+            if (superCompleted) {
+                // this wouldn't be necessary if StreamHandler made it possible to see what the current
+                // output stream is set to
+                this.outputStreamMemo = outputStream;
+                super.setOutputStream(outputStream);
+            }
         }