Changeset 13934 in josm

Timestamp:

2018-06-15T18:24:09+02:00 (6 years ago)

Author:

Don-vip

Message:

fix PMD/Javadoc issues

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/downloadtasks/DownloadOsmTask.java (modified) (2 diffs)
• gui/download/overpass/OverpassWizardRegistration.java (modified) (1 diff)
• io/remotecontrol/handler/RequestHandler.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadOsmTask.java

@@ -402 +402 @@
          * @param reader OSM data reader
          * @param progressMonitor progress monitor
-         * @deprecated Use {@link #DownloadTask(DownloadParams, OsmServerReader, ProgressMonitor)}
+         * @deprecated Use {@link DownloadOsmTask.DownloadTask#DownloadTask(DownloadParams, OsmServerReader, ProgressMonitor)}
          */
         @Deprecated
@@ -415 +415 @@
          * @param progressMonitor progress monitor
          * @param zoomAfterDownload If true, the map view will zoom to download area after download
-         * @deprecated Use {@link #DownloadTask(DownloadParams, OsmServerReader, ProgressMonitor, boolean)}
+         * @deprecated Use {@link DownloadOsmTask.DownloadTask#DownloadTask(DownloadParams, OsmServerReader, ProgressMonitor, boolean)}
          */
         @Deprecated

trunk/src/org/openstreetmap/josm/gui/download/overpass/OverpassWizardRegistration.java

@@ -94 +94 @@
 
     /**
-     * Wizard callbacks required by {@link OverpassQueryWizard#startWizard(OverpassWizardCallbacks)}
+     * Wizard callbacks required by {@link OverpassWizardRegistration.OverpassQueryWizard#startWizard(OverpassWizardCallbacks)}
      * @author Michael Zangl
      * @since 13930

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/RequestHandler.java

@@ -308 +308 @@
     }
 
+    private boolean get(String key) {
+        return get(key, Boolean::parseBoolean, () -> false);
+    }
+
     private boolean isLoadInNewLayer() {
         return get("new_layer", Boolean::parseBoolean, () -> Config.getPref().getBoolean(loadInNewLayerKey, loadInNewLayerDefault));
-    }
-
-    private boolean is(String key) {
-        return get(key, Boolean::parseBoolean, () -> false);
     }
 
@@ -320 +320 @@
                 .withNewLayer(isLoadInNewLayer())
                 .withLayerName(args.get("layer_name"))
-                .withLocked(is("layer_locked"))
+                .withLocked(get("layer_locked"))
                 .withDownloadPolicy(get("download_policy", DownloadPolicy::of, () -> DownloadPolicy.NORMAL))
                 .withUploadPolicy(get("upload_policy", UploadPolicy::of, () -> UploadPolicy.NORMAL));