Changeset 13829 in josm for trunk

Timestamp:

2018-05-25T01:24:24+02:00 (7 years ago)

Author:

Don-vip

Message:

SonarQube - fix minor issues

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/imagery/WMSEndpointTileSource.java (modified) (1 diff)
• data/osm/DataSet.java (modified) (1 diff)
• data/osm/RelationMemberData.java (modified) (1 diff)
• gui/preferences/imagery/AddImageryPanel.java (modified) (1 diff)
• io/audio/fx/JavaFxMediaPlayer.java (modified) (1 diff)
• io/imagery/WMSImagery.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/imagery/WMSEndpointTileSource.java

@@ -60 +60 @@
     @Override
     public String getTileUrl(int zoom, int tilex, int tiley) {
-        String bbox = getBbox(zoom, tilex, tiley, wmsi.belowWMS130() ? false : getTileProjection().switchXY());
+        String bbox = getBbox(zoom, tilex, tiley, !wmsi.belowWMS130() && getTileProjection().switchXY());
 
         // Using StringBuffer and generic PATTERN_PARAM matcher gives 2x performance improvement over replaceAll

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -103 +103 @@
  * @author imi
  */
-public final class DataSet implements OsmData<OsmPrimitive, Node, Way, Relation>, ProjectionChangeListener, Lockable {
+public final class DataSet implements OsmData<OsmPrimitive, Node, Way, Relation>, ProjectionChangeListener {
 
     /**

trunk/src/org/openstreetmap/josm/data/osm/RelationMemberData.java

@@ -65 +65 @@
     @Override
     public OsmPrimitiveType getDisplayType() {
-        return memberType;
+        return getMemberType();
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/AddImageryPanel.java

@@ -53 +53 @@
     private JComboBox<String> minimumCacheExpiryUnit;
     private TimeUnit currentUnit;
-
 
     /**

trunk/src/org/openstreetmap/josm/io/audio/fx/JavaFxMediaPlayer.java

@@ -41 +41 @@
     private MediaPlayer mediaPlayer;
 
-    JavaFxMediaPlayer() throws JosmRuntimeException {
+    JavaFxMediaPlayer() {
         try {
             initFxPlatform();

trunk/src/org/openstreetmap/josm/io/imagery/WMSImagery.java

@@ -18 +18 @@
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
-import java.util.function.Function;
+import java.util.function.UnaryOperator;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
@@ -546 +546 @@
 
     private Bounds parseBoundingBox(XMLStreamReader reader, Projection conv) {
-        Function<String, String> attrGetter = tag -> belowWMS130() ?
+        UnaryOperator<String> attrGetter = tag -> belowWMS130() ?
                 reader.getAttributeValue(null, tag)
                 : reader.getAttributeValue(WMS_NS_URL, tag);
@@ -589 +589 @@
             // If the url doesn't already have GetCapabilities, add it in
             getCapabilitiesUrl = new URL(serviceUrlStr);
-            ret = serviceUrlStr;
             if (getCapabilitiesUrl.getQuery() == null) {
                 ret = serviceUrlStr + '?' + CAPABILITIES_QUERY_STRING;